No Code Attached Yet J4 Issue ?
avatar chmst
chmst
26 Jan 2022

Steps to reproduce the issue### Steps to reproduce the issue

This is probably related to php version 8 as it is not in online applications with php7.3
Maybe also related to com_language, I got an error 500 on the ajax request with and answer related to com_language when I was in a german backend.

In quickicons, set the icon for global check-in to "items with count".

Expected result

A number as in other icons

Actual result

The spinner never stops.

grafik

System information (as much as possible)

win11, xampp, php 8.0.14 joomla 4.0.6

Additional comments

avatar chmst chmst - open - 26 Jan 2022
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Jan 2022
avatar chmst chmst - labeled - 26 Jan 2022
avatar chmst chmst - labeled - 26 Jan 2022
avatar chmst chmst - change - 26 Jan 2022
The description was changed
avatar chmst chmst - edited - 26 Jan 2022
avatar brianteeman
brianteeman - comment - 27 Jan 2022

on a monolingual site with php 8.0.10 I could not replicate this

avatar chmst
chmst - comment - 27 Jan 2022

Was the number of folder > 0?

Mine is a multilingual site too and it happens also when I choose English as language.
I found this in the ajax request answer, seems to be the plural language string.

-- libraries\src\Language\Text.php(251): sprintf('Globales Freige...', 2)
-- administrator\components\com_checkin\src\Controller\DisplayController.php(120): Joomla\CMS\Language\Text::plural('COM_CHECKIN_N_Q...', 2)\n
-- \libraries\src\MVC\Controller\BaseController.php(730): Joomla\Component\Checkin\Administrator\Controller\DisplayController->getQuickiconContent()

avatar brianteeman
brianteeman - comment - 27 Jan 2022

it was 1

avatar chmst
chmst - comment - 27 Jan 2022

Then it is another language key which does not replace the %D

COM_CHECKIN_N_QUICKICON_SRONLY="Globales Freigeben: %D Tabellen haben gesperrte Einträge."

avatar brianteeman
brianteeman - comment - 27 Jan 2022

I did locate another problem though - note the count. only the first image has the correct count

image

image

image

avatar chmst
chmst - comment - 27 Jan 2022

The first one counts the number of records, the quickicon counts the number of folders. I agree that this is not self explaining.

avatar brianteeman
brianteeman - comment - 27 Jan 2022

folders is wrong. you are checking in items

avatar chmst
chmst - comment - 27 Jan 2022

Can you open another issue then? Then it will not be forgotten if this one will be closed.

avatar brianteeman
brianteeman - comment - 27 Jan 2022

will do

avatar chmst
chmst - comment - 27 Jan 2022

The german language strings use %D instead of %d as placeholder for variables in this language file (com_checkin.ini). With php 7 this does not matter but in php 8
@tecpromotion @zero-24.

Solution in the german language file or in the sprintf function of text.php (in case of other languages who also use %D)?
Regex is not what I want to touch ...

avatar tecpromotion
tecpromotion - comment - 27 Jan 2022
avatar chmst chmst - change - 27 Jan 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-01-27 19:05:27
Closed_By chmst
Labels Added: J4 Issue ?
avatar chmst chmst - close - 27 Jan 2022
avatar chmst
chmst - comment - 27 Jan 2022

So I close this for now as the bug is fixed in the german language file. Thanks @tecpromotion

Add a Comment

Login with GitHub to post a comment