[#36860] - [4.2] Enable/disable 'Upload&Install' button on the basis of checkbox value
- Fixed in Code Base
- 9 Mar 2022
- Medium
- Build: 4.1-dev
- # 36860
- Diff
- Shubhamverma2796:issue_36274
User tests: Successful: Unsuccessful:
Pull Request for Issue #36274 and #35055 .
Summary of Changes
Added disabled state to the "UploadAndInstall" button.
Testing Instructions
1.System-->Update-->Joomla.
2. Click on "Update your site by manually uploading the update package".
3. Button and checkbox are disabled initially.
4. Upload a file greater than 40 MB, checkbox and button are still disabled.
5. upload a file less than 40 MB, the checkbox is enabled. Check in the box, the button gets enabled.
6. again upload a file greater than 40 MB, checkbox and button get disabled again.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
2022-02-01.01-12-47.mp4
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate | ⇒ | Administration com_joomlaupdate JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
After discussing with @Shubhamverma2796 we agreed, that the flow should also include the file input field, too. So a un-disable chain: field => checkbox => button
Thanks for the PR @Shubhamverma2796 and thanks for continuing working on it!
| Status | Ready to Commit | ⇒ | Pending |
Removed RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
richard67
- 
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
I have tested this item
For any future testers, please note that you'll need to rebuild the JS assets for com_joomlaupdate even if you apply the patch via Joomla! Patch Tester. I had to run npm run build:js -- build/media_source/com_joomlaupdate before I could reproduce the changes successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.
| Title |
|
||||||
| Labels |
Added:
?
|
||
Thanks for this very nice enhancement, I rebased it to 4.2 as it's a new thing.
@Shubhamverma2796 Please consider doing the same in a separate PR for the following. Thanks.
@Shubhamverma2796 Please consider doing the same in a separate PR for the following. Thanks.
I am not getting this screen.
@Shubhamverma2796 Please consider doing the same in a separate PR for the following. Thanks.
I am not getting this screen.
I got the screen. Should I open a new issue or directly open a pr because #35055 is closed.
@Shubhamverma2796 Please create a new PR to disable the Start update button until the checkbox is checked.
| Labels |
Added:
?
Removed: ? |
||
@Shubhamverma2796 Please create a new PR to disable the
Start updatebutton until the checkbox is checked.
Sure. I will do it ASAP.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-09 18:50:48 |
| Closed_By | ⇒ | roland-d |
Thank you everybody :)
I have tested this item✅ successfully on a3ce59d
Working as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36860.