[#36861] - [3.10] Remove FLoC
- Fixed in Code Base
- 20 Feb 2022
- Medium
- Build: 3.10-dev
- # 36861
- Diff
- brianteeman:floc3
User tests: Successful: Unsuccessful:
backport of #36855 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql MS SQL com_config Language & Strings Installation Libraries |
| Labels |
Added:
Language Change
?
|
||
FYI as 4.1.0 is in RC and language freeze mode which does not allow language changes and technically this is a language change as the strings are removed as well as we usually only try to do non-critical bug fixes. This removal change will go into 4.1.1 and 3.10.7 as coordinated with @bembelimen
As there is also no major impact of the header present or not this does not have to go into the very next release anyway.
Please dont pretend that it is anything to do with a language string freeze.
Obviously removing a string has zero impact on a translation.
And of course you're quite happy to merge other pull requests that actually change a language string
And of course you're quite happy to merge other pull requests that actually change a language string
The last merges have been coordinated between benjamin, me and the TTs. But we should always try to stick to the rules we apply on ourself. Yes we are not perfect but there is no change that has an impact in the real world here so I dont think we have to ship that with the next possible release in this special case.
And as mentiond in my message its not just the language string thing ;)
@richard67 didnt we also have to comment (not remove) the old update sqls which added the postinstall? Or would than in this case the new SQl fail to execute?
Why should the new SQL fail? When there is no record which matches the where clause, it will simply not do anything, but it will not fail.
Changing the old SQL is not necessary. Personally I would do it because in my opinion it is silly to insert something just to remove it later, and we safely could change them. But some people always make a big yelling when we change old update SQL, and because it’s not really necessary and to avoid discussions I would say leave the old SQL as they are.
Thanks for checking
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36861.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36861.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36861.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-20 09:27:16 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merging
thx
@richard67 didnt we also have to comment (not remove) the old update sqls which added the postinstall? Or would than in this case the new SQl fail to execute?