? Pending

User tests: Successful: Unsuccessful:

avatar pritam825
pritam825
21 Jan 2022

Pull Request for Issue #36758 .

Summary of Changes

When the screen is less than 992px wide Hits and ID columns was disappearing but now it will appear

Testing Instructions

go to content -> article -> do screen size less than 992px

Actual result BEFORE applying this Pull Request

Hits and ID columns was disappearing

Expected result AFTER applying this Pull Request

now, Hits and ID columns are Appearing

avatar pritam825 pritam825 - open - 21 Jan 2022
avatar pritam825 pritam825 - change - 21 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2022
Category Administration com_content
avatar pritam825 pritam825 - change - 21 Jan 2022
The description was changed
avatar pritam825 pritam825 - edited - 21 Jan 2022
avatar pritam825
pritam825 - comment - 21 Jan 2022

@richard67 Build is failing, will it create any problem for testing, or will i have to fix this?

avatar richard67
richard67 - comment - 21 Jan 2022

@richard67 Build is failing, will it create any problem for testing, or will i have to fix this?

@pritam825 The failing build is not related to your PR, it's a general problem we currently have in the 4.x-dev branches and on which we are already working. So nothing to do or to fix for you, just stay patiend and wait for 2 human testers ?

avatar pritam825
pritam825 - comment - 21 Jan 2022

@richard67 oh ok thanks, I got tensed after seeing that build is failing ?, now, I am fine thanks :)

avatar brianteeman
brianteeman - comment - 21 Jan 2022

same comment as #36771

avatar richard67
richard67 - comment - 21 Jan 2022

@brianteeman Well, here we had an issue, #36758 . But of course still not really a necessary fix.

avatar brianteeman
brianteeman - comment - 21 Jan 2022

Just because an issue is reported doesn't mean it is correct.

avatar richard67
richard67 - comment - 21 Jan 2022

Sometimes they are a matter of taste, one sees an issue, another one not. I don't think I always have the wisdom to decide alone what is what, so sometimes I am waiting for opinions.

avatar pritam825
pritam825 - comment - 21 Jan 2022

oh ok sorry, I thought it was issue, so I have changed according to the problems

avatar pritam825
pritam825 - comment - 21 Jan 2022

Just because an issue is reported doesn't mean it is correct.

yes right, now will I have to close this pr?

avatar pritam825
pritam825 - comment - 21 Jan 2022

I thought this was the problem, when doing screen size less than 992px , right scroll is not coming, because of that we were not be able to see the hits and it.
Screenshot (1909)

so I have solved this in this manner, so that right scroll comes, we will be able to see
Screenshot (1910)

@richard67 sir, @brianteeman sir sorry for disturbing you again, can you please confirm this, if you feel it wasn't problem I will close the PR, Thanks in Advance .

avatar bembelimen bembelimen - change - 23 Jan 2022
Labels Added: ?
avatar Ravi-chandra69
Ravi-chandra69 - comment - 23 Jan 2022

I have tested this item successfully on c229987


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36767.

avatar Ravi-chandra69 Ravi-chandra69 - test_item - 23 Jan 2022 - Tested successfully
avatar richard67 richard67 - change - 24 Jan 2022
Labels Added: ?
Removed: ?
avatar richard67 richard67 - alter_testresult - 24 Jan 2022 - Ravi-chandra69: Tested successfully
avatar pritam825
pritam825 - comment - 25 Jan 2022

Screenshot (1935)

after the pr and right one is showing before the pr, the advantage is that after the pr hits and ID are also appearing , Can I please get some feedback, Thanks in advance

avatar brianteeman
brianteeman - comment - 25 Jan 2022

Which one looks broken to you?

For me the one on the left looks broken and I can guarantee someone will report that as broken.

avatar pritam825
pritam825 - comment - 25 Jan 2022

sir, I am not able to find any broken thing in this, can you please tell, which part of the left, you have found broken, so That I will work accordingly.

avatar brianteeman
brianteeman - comment - 25 Jan 2022

image

avatar pritam825
pritam825 - comment - 25 Jan 2022

image

before the pr it's still showing the same break ,
image before the pr ->
Screenshot (1950)
after the pr->

Screenshot (1953)

avatar Quy
Quy - comment - 5 Feb 2022

The solution is not to display many/more columns at smaller viewports. On an iPad, it will try to show all the columns by zooming out thus displaying everything smaller where you have to zoom in and swipe left and right making it a bad UX or the extra margin/space on the right as reported earlier.

I would say leave it as it. Try viewing in landscape to see these columns.

avatar brianteeman
brianteeman - comment - 22 Jun 2022

This should be closed. j4.2 now has more fine grained user control of which columns to be displayed

avatar Quy Quy - change - 22 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-22 14:33:14
Closed_By Quy
avatar Quy Quy - close - 22 Jun 2022

Add a Comment

Login with GitHub to post a comment