Composer Dependency Changed ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar niharikamahajan02
niharikamahajan02
21 Jan 2022

Summary of Changes

Did some changes in TOOLBAR.

Actual result BEFORE applying this Pull Request

SHOWING SCREENSHOT OF ARTICLES SECTION.
image

image

Expected result AFTER applying this Pull Request

SHOWING SCREENSHOT OF CHANGES DONE IN ARTICLE SECTION( CAN BE VIEWED IN OTHER CONTENT CATEGORIES TOO)
image

image

avatar niharikamahajan02 niharikamahajan02 - open - 21 Jan 2022
avatar niharikamahajan02 niharikamahajan02 - change - 21 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2022
Category Administration Templates (admin) NPM Change External Library Composer Change
avatar niharikamahajan02 niharikamahajan02 - change - 21 Jan 2022
Title
Improvement in frontend
[4.0] Improvement in frontend
avatar niharikamahajan02 niharikamahajan02 - edited - 21 Jan 2022
avatar brianteeman
brianteeman - comment - 21 Jan 2022

Why? What is the reason behind these changes?

avatar niharikamahajan02
niharikamahajan02 - comment - 21 Jan 2022

There is a wide gap before search tool , so it is better to minimize that so that toolbar starts from leftmost side . The screen would look much better.

avatar brianteeman
brianteeman - comment - 21 Jan 2022

Changing from right aligned to left aligned is a subjective opinion not a fact.

avatar richard67
richard67 - comment - 21 Jan 2022

The screen would look much better.

@niharikamahajan02 It's not only a question what looks better (and that's a subjective thing, i.e. matter of taste), it is more important which way you can navigate faster and how you can find things more quickly.

Having the search tool bar right aligned like it is without your PR is in my opinion better. We can find the paging and the ordering drop downs more quickly in my opinion.

So I am not in favour of this PR. I think it should be closed.

avatar niharikamahajan02
niharikamahajan02 - comment - 21 Jan 2022

Ok sir , thanks for the feedback . Got the point.

avatar niharikamahajan02 niharikamahajan02 - change - 21 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-21 15:25:34
Closed_By niharikamahajan02
Labels Added: Composer Dependency Changed ? NPM Resource Changed
avatar niharikamahajan02 niharikamahajan02 - close - 21 Jan 2022

Add a Comment

Login with GitHub to post a comment