[#36766] - [4.1] Finder: Fixing Content Map field
- Fixed in Code Base
- 5 Jun 2022
- Medium
- Build: 4.1-dev
- # 36766
- Diff
- Hackwar:4.1-finder-mapfield
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is about the "Content Map" filter field in the "Index" view of Smart Search. While changing the taxonomy table to a nested set schema, I forgot to convert this form field. This means that right now it returns more or less garbage. It should display for example the whole category tree properly indented in the dropdown.
Testing Instructions
- Install Joomla with some data, for example the testing sampledata.
- Go to "Smart Search -> Index"
- Open the filter dropdown and the "Content Map" filter. The entries are rather jumbled.
- Apply this PR.
- Reload the page and check the filter again. Now everything is aligned properly and indented properly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
?
|
||
Can you provide me with the database? I don't see how that is possible right now.
Can you provide me with the database? I don't see how that is possible right now.
Nothing fancy. It a default installation, with our testing sample data, since 4.0, updated to 4.1 :)
ok, I'll try to see what is happening there. Did it stay the same even after clearing index and reindexing?
Yeah, works only when I Clear index and run Index again.
But I not sure that everyone will do it when will see this error.
Maybe just add empty() check somewhere before foreach.
I have tested this item
The content of the dropdown already was nice. After applying the patch I see no difference. Maybe this is a good thing ?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36766.
@superknutsel Can you explain a bit further? How did you test? Did it REALLY have the right indentation for categories for example in that dropdown?
Hi @Hackwar I hope I did it like intended. Just had a look at the "Smart Search > Index > Filter Options > Select Content Map dropdown" and it all looked fine. Even made a screenshot just to make sure before I applied the patch.
What might be a thing is that I used the Joomla Patch Tester in my site that was on 4.2.0 alpha1 dev.
I just used my most up to date test site and did not realise the version.
If it's not the version to test this agains then sorry, I will make a site with a different release for this to test again.
The main issue is, that the dropdown should contain among other things a list of all categories and they should be correctly indented according to their level. The current code simply does not do that, so I would be really astonished if it worked correctly for you.
I have tested this item
@Hackwar After retesting with more categories added at different levels I see what you mean. I was mistakenly thinking the demo data would be enough for this test. And after doing this I can see what the issue is and that the patch is fixing it.
Thanks for your reply and explanation.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36766.
Restore test result
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36766.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36766.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36766.
| Labels |
Added:
?
|
||
@bembelimen you might wanna consider merging this for 4.14 as it's directly fixing a regression
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-05 19:08:26 |
| Closed_By | ⇒ | bembelimen |
Thx
I got on test installation:
Something went wrong here
joomla-cms/administrator/components/com_finder/src/Field/ContentmapField.php
Line 110 in bae8a8a