User tests: Successful: Unsuccessful:
Pull Request for Issue #36459.
There is no visual indicator that the task has failed in the default Scheduled tasks view.
There is a visual indicaator that the task is failing:
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Repository NPM Change |
Labels |
Added:
Language Change
NPM Resource Changed
?
|
@ditsuke Could you check the previous comment? Thanks in advance.
Labels |
Added:
?
|
I have tested this item
Labels |
Removed:
?
|
I think you forgot to declare this -> "com_scheduler.admin-view-tasks-css"
@pritam825 Have you "compiled" the css with npm ci
or npm run build:css
as described here https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment after having applied the patch? This will copy the css from "build/media_source/com_scheduler/css" to "media/com_scheduler/css".
@pritam825 Have you "compiled" the css with
npm ci
ornpm run build:css
as described here https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment after having applied the patch? This will copy the css from "build/media_source/com_scheduler/css" to "media/com_scheduler/css".
sorry sir, I forgot to use npm run build:css, Thanks sir
It's still giving me the same error
It's still giving me the same error
@pritam825 Try npm ci
instead of npm run build:css
and clear browser cache before testing again.
@richard67 thanks, now it's working fine.
Working as expected
@pritam825 Then mark your test result in the issue tracker. Thanks in advance.
ok sir, Thanks
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Back to pending.
@ditsuke ,
Can you please fix the conflicts?
Status | Ready to Commit | ⇒ | Pending |
Labels |
Added:
Conflicting Files
|
Status | Pending | ⇒ | Ready to Commit |
RTC
@richard67 @jwaisner thanks!
Labels |
Added:
?
?
Removed: Conflicting Files |
@richard67 applied
I have tested this item
I've restored the previous test results since the change after that was just removal of 2 unused CSS classes in the markup and an improvement on the language string for the tool tip.
In addition I have tested it, too, just to be sure.
=> RTC still valid.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-17 20:03:10 |
Closed_By | ⇒ | bembelimen | |
Labels |
Removed:
?
|
Thx
Thanks!
Please look at other "tooltips" and create this one in the same way.