? Language Change NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
21 Jan 2022

Pull Request for Issue #36459.

Summary of Changes

  • Adds an icon as a visual indicator for failing tasks.
  • Includes an on-hover tooltip for accessibility (review).

Testing Instructions

  • Create a new scheduled task with routine GET Request, setting an invalid URL as the target
    .
  • Let it run. It will fail.

Actual result BEFORE applying this Pull Request

There is no visual indicator that the task has failed in the default Scheduled tasks view.

before-patch

Expected result AFTER applying this Pull Request

There is a visual indicaator that the task is failing:
after-patch

Documentation Changes Required

None

avatar ditsuke ditsuke - open - 21 Jan 2022
avatar ditsuke ditsuke - change - 21 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2022
Category Administration Language & Strings Repository NPM Change
avatar ditsuke ditsuke - change - 21 Jan 2022
Labels Added: Language Change NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 21 Jan 2022

Please look at other "tooltips" and create this one in the same way.

	<span class="icon-info-circle" aria-hidden="true" tabindex="0"></span>
	<div role="tooltip" class="text-start" id="tip<?php echo $language->code; ?>">
		<?php echo Text::_('JGLOBAL_LANGUAGE_VERSION_NOT_PLATFORM'); ?>
	</div>

avatar richard67
richard67 - comment - 23 Jan 2022

@ditsuke Could you check the previous comment? Thanks in advance.

avatar ditsuke ditsuke - change - 23 Jan 2022
Labels Added: ?
avatar chmst chmst - test_item - 23 Jan 2022 - Tested successfully
avatar chmst
chmst - comment - 23 Jan 2022

I have tested this item successfully on 3febb57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar richard67 richard67 - change - 24 Jan 2022
Labels Removed: ?
avatar richard67 richard67 - alter_testresult - 24 Jan 2022 - chmst: Tested successfully
avatar pritam825
pritam825 - comment - 31 Jan 2022

Screenshot (1981)
After applying the patch it' giving me error with this -> "There is no "com_scheduler.admin-view-tasks-css" asset of a "style" type in the registry".

avatar pritam825
pritam825 - comment - 31 Jan 2022

I think you forgot to declare this -> "com_scheduler.admin-view-tasks-css"

avatar richard67
richard67 - comment - 31 Jan 2022

@pritam825 Have you "compiled" the css with npm cior npm run build:cssas described here https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment after having applied the patch? This will copy the css from "build/media_source/com_scheduler/css" to "media/com_scheduler/css".

avatar pritam825
pritam825 - comment - 31 Jan 2022

@pritam825 Have you "compiled" the css with npm cior npm run build:cssas described here https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment after having applied the patch? This will copy the css from "build/media_source/com_scheduler/css" to "media/com_scheduler/css".

sorry sir, I forgot to use npm run build:css, Thanks sir

avatar pritam825
pritam825 - comment - 31 Jan 2022

It's still giving me the same error

avatar richard67
richard67 - comment - 31 Jan 2022

It's still giving me the same error

@pritam825 Try npm ci instead of npm run build:css and clear browser cache before testing again.

avatar pritam825
pritam825 - comment - 31 Jan 2022

@richard67 thanks, now it's working fine.
Working as expected
Screenshot (1984)

avatar richard67
richard67 - comment - 31 Jan 2022

@pritam825 Then mark your test result in the issue tracker. Thanks in advance.

avatar pritam825
pritam825 - comment - 31 Jan 2022

ok sir, Thanks

avatar pritam825 pritam825 - test_item - 31 Jan 2022 - Tested successfully
avatar pritam825
pritam825 - comment - 31 Jan 2022

I have tested this item successfully on a9d6300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar richard67
richard67 - comment - 31 Jan 2022

@chmst Could you test again? Thanks in advance.

avatar jwaisner jwaisner - test_item - 31 Jan 2022 - Tested successfully
avatar jwaisner
jwaisner - comment - 31 Jan 2022

I have tested this item successfully on a9d6300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2022
The description was changed
avatar jwaisner jwaisner - change - 31 Jan 2022
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Jan 2022
avatar jwaisner
jwaisner - comment - 31 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar jwaisner
jwaisner - comment - 31 Jan 2022

Back to pending.

@ditsuke ,

Can you please fix the conflicts?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar jwaisner jwaisner - change - 31 Jan 2022
Status Ready to Commit Pending
avatar richard67 richard67 - change - 1 Feb 2022
Labels Added: Conflicting Files
avatar richard67 richard67 - alter_testresult - 1 Feb 2022 - pritam825: Tested successfully
avatar richard67 richard67 - alter_testresult - 1 Feb 2022 - jwaisner: Tested successfully
avatar richard67
richard67 - comment - 1 Feb 2022

@ditsuke @jwaisner I've allowed myself to fix the merge conflict and to add back the previous results since the change after those just were a clean branch update with the conflict fix. => RTC again.

avatar richard67 richard67 - change - 1 Feb 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar ditsuke
ditsuke - comment - 1 Feb 2022
avatar richard67
richard67 - comment - 11 Mar 2022

@ditsuke Could you implement @Quy 's suggestions? Thanks in advance.

avatar ditsuke ditsuke - change - 15 Mar 2022
Labels Added: ? ?
Removed: Conflicting Files
avatar ditsuke
ditsuke - comment - 15 Mar 2022

@richard67 applied

avatar richard67 richard67 - alter_testresult - 15 Mar 2022 - jwaisner: Tested successfully
avatar richard67 richard67 - alter_testresult - 15 Mar 2022 - pritam825: Tested successfully
avatar richard67
richard67 - comment - 15 Mar 2022

I have tested this item successfully on 05dde69

I've restored the previous test results since the change after that was just removal of 2 unused CSS classes in the markup and an improvement on the language string for the tool tip.

In addition I have tested it, too, just to be sure.

=> RTC still valid.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36765.

avatar richard67 richard67 - test_item - 15 Mar 2022 - Tested successfully
avatar bembelimen bembelimen - close - 17 Mar 2022
avatar bembelimen bembelimen - merge - 17 Mar 2022
avatar bembelimen bembelimen - change - 17 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-17 20:03:10
Closed_By bembelimen
Labels Removed: ?
avatar bembelimen
bembelimen - comment - 17 Mar 2022

Thx

avatar ditsuke
ditsuke - comment - 18 Mar 2022

Thanks!

Add a Comment

Login with GitHub to post a comment