[#36728] - [3.10] [PHP 8.1] deprecated header() in WebApplication
- Fixed in Code Base
- 18 Jan 2022
- Medium
- Build: 3.10-dev
- # 36728
- Diff
- beat:patch-10
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fixes PHP 8.1 deprecation warning in Joomla 3.10.
Note in Joomla 4.0: Same PHP 8.1 deprecated issue is in libraries/vendor/joomla/application/src/AbstractWebApplication.php line 886 but it doesn't appear.
Testing Instructions
Use PHP 8.1 in Joomla 3.10
Enable debug mode (without Debug plugin enabled!) (not sure if CB also imight be needed to reproduce).
Go to administration home page
Actual result BEFORE applying this Pull Request
Deprecated: header(): Passing null to parameter #3 ($response_code) of type int is deprecated in libraries/src/Application/WebApplication.php on line 1101
Expected result AFTER applying this Pull Request
No warning.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Joomla 4 has
header(str_replace(\chr(0), '', $string), $replace, $code);maybe that could be back ported into Joomla 3.10 with this PR? No?
That zero-chars replacement is already in Joomla 3.10, even written cleaner, as a separate line:
Ah sorry missed that
Sent from my iPhone
On 18 Jan 2022, at 14:17, beat @.***> wrote:
Joomla 4 hasheader(str_replace(\chr(0), '', $string), $replace, $code);
maybe that could be back ported into Joomla 3.10 with this PR? No?That zero-chars replacement is already in Joomla 3.10, even written cleaner, as a separate line:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
No worries, checked before committing too to make sure that security-wise we're fine!
Ah sorry missed that
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-18 19:49:46 |
| Closed_By | ⇒ | zero-24 |
Joomla 4 has
maybe that could be back ported into Joomla 3.10 with this PR? No?