? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jan 2022

Summary of Changes

The message "Some update sites are disabled. You may want to check the Update Sites Manager." was not being displayed

Testing Instructions

Go to the list of update sites and if you have an extension installed disable the update site. If you dont have an extension installed then you can disabled the accredited translations update site
Go to Extensions Update and click on the Check Updates button in the toolbar

Actual result BEFORE applying this Pull Request

No warning about the disabled updates sites
image

Expected result AFTER applying this Pull Request

Warning and link is displayed
image

Documentation Changes Required

none

Notes

Assuming I read the code correctly the problem was due to the use of setmessage and the second message overwriting the first. So I changed the code to use enqueueMessage instead

avatar brianteeman brianteeman - open - 18 Jan 2022
avatar brianteeman brianteeman - change - 18 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2022
Category Administration com_installer
avatar richard67
richard67 - comment - 18 Jan 2022

I have tested this item successfully on 997d3b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36729.

avatar richard67 richard67 - test_item - 18 Jan 2022 - Tested successfully
avatar pritam825
pritam825 - comment - 18 Jan 2022

I have tested this item successfully on 997d3b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36729.

avatar pritam825 pritam825 - test_item - 18 Jan 2022 - Tested successfully
avatar richard67 richard67 - change - 18 Jan 2022
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 18 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36729.

avatar brianteeman brianteeman - change - 18 Jan 2022
Labels Added: ?
avatar richard67
richard67 - comment - 18 Jan 2022

I have tested this item successfully on c47258a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36729.

avatar richard67 richard67 - test_item - 18 Jan 2022 - Tested successfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 18 Jan 2022

I have tested this item successfully on c47258a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36729.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 18 Jan 2022 - Tested successfully
avatar richard67
richard67 - comment - 18 Jan 2022

RTC still valid.

avatar wilsonge wilsonge - change - 18 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-18 19:18:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Jan 2022
avatar wilsonge wilsonge - merge - 18 Jan 2022
avatar wilsonge
wilsonge - comment - 18 Jan 2022

Thanks!

avatar brianteeman
brianteeman - comment - 18 Jan 2022

thanks

Add a Comment

Login with GitHub to post a comment