Please review. Thanks

Please review. Thanks

Please check whether you have taken over all comments from your previous PRs.
Furthermore, I have the impression, but still have to test it, that again not all occurrences have been renamed.
Please also check this with a full text search over the whole repo.
And please keep the code up to date.

But sir , it is working fine after running the command (npm run build:js )

Should this also be adapted?

and

Perhaps with runTaskCron

And maybe also replace onAjaxRunSchedulerTest with onAjaxRunSchedulerTask?

@ditsuke what do you think about this improvements?

Please check this two code comments.

Also, please check the occurrences of 'test-task'.
This concerns file names, function calls and declarations.

@niharikamahajan02 sorry for all the comments but it's best to clean it straight away.

Also, please check the occurrences of 'test-task'. This concerns file names, function calls and declarations.

@niharikamahajan02 sorry for all the comments but it's best to clean it straight away.

No problem sir ? and yes it's better to clean them straight away now

Yes ,I would rename the file names, function calls and declarations also ?

Please suggest if something needs to be updated now . Thanks

@tecpromotion

@ditsuke what do you think about this improvements?

Thanks for tagging! I really like the changes so far.

Yes sir , changed the file name now.

@niharikamahajan02

Yes sir , changed the file name now.

Nicely done! You can resolve the suggestions I left above from your end.

Ok sir , thanks!

Actually for resolving the conflict I am doing git pull, and it's saying already up to date.
Even after that new changes made in administrator/components/com_scheduler/tmpl/tasks/default.php( which is causing conflict ) are not getting reflected.

Actually for resolving the conflict I am doing git pull, and it's saying already up to date. Even after that new changes made in administrator/components/com_scheduler/tmpl/tasks/default.php( which is causing conflict ) are not getting reflected.

I've opened a PR to update your branch to 4.1-dev and resolve conflicts.
PTAL niharikamahajan02#1.

Ok , so do I need to do something for now?

Ok , so do I need to do something for now?

Please merge the PR. It's on your fork.

ok ,done

This pull request has automatically rebased to 4.2-dev.

I've allowed myself to solve the conflicting files.

This pull requests has been automatically converted to the PSR-12 coding standard.

I rebased the PR and added back removed language strings and deprecated them.

This pull request has been automatically rebased to 5.1-dev.

@niharikamahajan02 please solve the unresolved conversations of this PR. I would like to see this merged into a following Joomla version, while Run Test is the correct name for the action the button is doing

please review it once , I think there are some changes to be done

please review it once , I think there are some changes to be done

@niharikamahajan02 It needs to resolve merge conflicts in files build/media_source/com_scheduler/joomla.asset.json and plugins/system/schedulerunner/schedulerunner.php. Maybe just use the clean files from the 5.1-dev branch and apply your changes again on them.

but they are already having "run test" in 5.1-dev

but they are already having "run test" in 5.1-dev

@niharikamahajan02 What do you mean? Drone tests are failing, and if you go to the bottom of this PR on GitHub you clearly see there are the 2 mentioned files which have merge conflicts. If you don't know how to solve them we can help, but maybe you can try it yourself first like I have described.

This pull request has been automatically rebased to 5.2-dev.

I was pointed to this PR after a comment of mine on #43665 (comment)

1. looks like the Commits on Dec 22, 2023 reverted all the changes, I see 'TEST_RUN' all over the place and no 'RUN TASK.
2. breaks the site(UserFactoryAwareTrait not found), seems that some of the merges of branches failed. (tried gh pr checkout 36725 and git fetch upstream pull/36725/head:run-task).
3. there are some merge issues with #43491

This branch, based on the current 5.2-dev, should work: https://github.com/brbrbr/joomla-cms/tree/test2run-task

I have tested this item ? unsuccessfully on 6880884

Could not apply the patch, so could not test. This was done on a fresh 5.2.0-beta1 site.

ERROR MESSAGE:
The file marked for modification does not exist: plugins/system/schedulerunner/schedulerunner.php

I have tested this item ? unsuccessfully on 6880884Could not apply the patch, so could not test. This was done on a fresh 5.2.0-beta1 site.

ERROR MESSAGE: The file marked for modification does not exist: plugins/system/schedulerunner/schedulerunner.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36725.

@bascherz If you go to this PR on GitHub and scroll to the bottom you will see that this PR has conflicting files, so I cannot really be tested.

This pull request has been automatically rebased to 5.3-dev.

This pull request has been automatically rebased to 6.0-dev.

Please close in favour of #45313