? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
9 Jan 2022

Pull Request for Issue # .

Summary of Changes

Update deleted files and folders to changes from PR #36097

With that PR, file '/api/components/com_media/src/Helper/AdapterTrait.php' has been moved to another place, see here: https://github.com/joomla/joomla-cms/pull/36097/files#diff-1a2d837d1837d03537622e5a3a17a9c4a41ace8ffe4872f703a783aa390a597e .

After that, the folder '/api/components/com_media/src/Helper' doesn't exist anymore in the sources and so will be empty on an updated site when the obsolete file has been deleted, see here: https://github.com/joomla/joomla-cms/tree/4.1-dev/api/components/com_media/src .

So the file and the folder should be deleted on update.

Regarding the comment "// From 4.1.0-beta3 to 4.1.0-rc1": According to the last release announcement for 4.1 Beta 3, RC will come as next. I hope I was not too optimistic with my comment.

Testing Instructions

Code review, or build new packages on the current 4.1-dev branch (PR #36097 is not yet included in any nightly build) and update a 4.1 Beta 3 to the newly built update package. The update a 4.1 Beta 3 to the update package created by drone for this PR here, and compare the results.

Actual result BEFORE applying this Pull Request

File '/api/components/com_media/src/Helper/AdapterTrait.php' and folder '/api/components/com_media/src/Helper' are not deleted on update.

Expected result AFTER applying this Pull Request

File '/api/components/com_media/src/Helper/AdapterTrait.php' and folder '/api/components/com_media/src/Helper' are deleted on update.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 9 Jan 2022
avatar richard67 richard67 - change - 9 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2022
Category Administration com_admin
avatar richard67 richard67 - change - 9 Jan 2022
Labels Added: ?
429c953 9 Jan 2022 avatar richard67 Grr
avatar richard67 richard67 - change - 9 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 9 Jan 2022
avatar bembelimen bembelimen - change - 15 Jan 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-15 00:27:25
Closed_By bembelimen
avatar bembelimen bembelimen - close - 15 Jan 2022
avatar bembelimen bembelimen - merge - 15 Jan 2022
avatar bembelimen
bembelimen - comment - 15 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment