Release Blocker ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
9 Jan 2022

Pull Request for 67215a7#r63168677 .

Summary of Changes

Fix error from the above commit.

I have no idea yet if we have more such errors in the 4.0-dev branch.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Wrong condition. On PHP 8.1+ it will raise an error due to trim with null argument, and (regardless of PHP version) the read more will be shown when the full text is null.

Expected result AFTER applying this Pull Request

Right condition. The read more and the full text are only added if the full text is not null and the trimmed full text is not an empty string.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 9 Jan 2022
avatar richard67 richard67 - change - 9 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2022
Category Administration com_content
avatar richard67 richard67 - change - 9 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 9 Jan 2022
avatar richard67 richard67 - change - 9 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 9 Jan 2022
avatar richard67 richard67 - change - 9 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 9 Jan 2022
avatar richard67 richard67 - change - 9 Jan 2022
The description was changed
avatar richard67 richard67 - edited - 9 Jan 2022
avatar wilsonge wilsonge - change - 9 Jan 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-09 17:07:55
Closed_By wilsonge
Labels Added: Release Blocker ?
avatar wilsonge wilsonge - close - 9 Jan 2022
avatar wilsonge wilsonge - merge - 9 Jan 2022
avatar wilsonge
wilsonge - comment - 9 Jan 2022

Oops thanks!

Add a Comment

Login with GitHub to post a comment