Feeling Lucky
?
[#36514] - [4.0] Another set of J Prefix removals + JDEBUG standard way of calling
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 36514
- Diff
- PhilETaylor:jprfix
User tests: Successful: Unsuccessful:
Summary of Changes
Cleanup of technical debt
Replacing JPrefixed class names with their new fqcn (or imported class name)
Replace the following types of JDEBUG Profiler calls
!JDEBUG ?: $this->profiler->mark('afterRoute');
JDEBUG ? $this->profiler->mark('afterRoute') : null;with this modern standard.
JDEBUG && $this->profiler->mark('afterRoute');Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Technical debt
Expected result AFTER applying this Pull Request
Less Technical debt.
Better static analysis and developer experience.
Less reliance of the legacy name classmap which can then be removed in 5.0
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_categories com_checkin com_contact com_content com_cpanel com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_menus com_messages com_modules |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 1 Jan 2022
The whole PR needs testing and reviewing and two human people to say they are happy with it.
pritam825
- comment
- 1 Jan 2022
ok
wilsonge
- comment
- 4 Jan 2022
pretty much all the display controller need the fqcn for InputFilter I'm afraid :(
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:23 |
| Closed_By | ⇒ | PhilETaylor |
Yoh have changed the same code to one line code, so for this is this need to be tested?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36514.