Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36515] - [4.1] Simplify Requirements for Task Routine XMLs

? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
1 Jan 2022

Pull Request for Issue #36449.

Summary of Changes

  • Fixes form for the Image Size Check task routine and improves a language string for clarity.
  • Removes requirement of the "showFront" attribute for the task_params fieldset.

Testing Instructions

  • Admin > System > Scheduled Tasks
  • Click "Create Task" or similar
  • Select "Image Size Check" routine
  • Fill in the form and save

Actual result BEFORE applying this Pull Request

  • Form fails to submit due to validation error (missing required data).
  • Routine XMLs require a showFront="true" attribute.

Expected result AFTER applying this Pull Request

  • Form is submitted, task is created.
  • Routine XMLs no longer require require the attribute to work correctly.

Documentation Changes Required

-

avatar ditsuke ditsuke - open - 1 Jan 2022
avatar ditsuke ditsuke - change - 1 Jan 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2022
Category ⇒ Administration Language & Strings Front End Plugins
avatar ditsuke ditsuke - change - 1 Jan 2022
Labels Added: Language Change ?
avatar Kostelano
Kostelano - comment - 1 Jan 2022

I have tested this item ✅ successfully on 0d0c644

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar Kostelano Kostelano - test_item - 1 Jan 2022 - Tested successfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 2 Jan 2022

I have tested this item ✅ successfully on 8cdd8ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 2 Jan 2022 - Tested successfully
avatar jwaisner
jwaisner - comment - 3 Jan 2022

I have tested this item ✅ successfully on 8cdd8ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar jwaisner jwaisner - test_item - 3 Jan 2022 - Tested successfully
avatar jwaisner jwaisner - change - 3 Jan 2022
The description was changed
Status Pending ⇒ Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Jan 2022
avatar jwaisner
jwaisner - comment - 3 Jan 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar bembelimen bembelimen - change - 8 Jan 2022
Labels Added: ?
avatar ditsuke ditsuke - change - 8 Jan 2022
Title
…
[4.1] Fix Form for Image Size Check Task Routine
[4.1] Simplify Requirements for Task Routine XMLs
avatar ditsuke ditsuke - edited - 8 Jan 2022
avatar ditsuke ditsuke - change - 8 Jan 2022
The description was changed
avatar ditsuke ditsuke - edited - 8 Jan 2022
avatar ditsuke
ditsuke - comment - 8 Jan 2022

Needs tests again I believe

avatar Kostelano
Kostelano - comment - 8 Jan 2022

I have tested this item ✅ successfully on 9f11de3

After the changes, everything works.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar Kostelano Kostelano - test_item - 8 Jan 2022 - Tested successfully
avatar bembelimen
bembelimen - comment - 10 Jan 2022

I have tested this item ✅ successfully on 9f11de3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36515.

avatar bembelimen bembelimen - test_item - 10 Jan 2022 - Tested successfully
avatar bembelimen bembelimen - close - 10 Jan 2022
avatar bembelimen bembelimen - merge - 10 Jan 2022
avatar bembelimen bembelimen - change - 10 Jan 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-01-10 01:20:19
Closed_By ⇒ bembelimen
avatar bembelimen
bembelimen - comment - 10 Jan 2022

Thx

Add a Comment

Login with GitHub to post a comment