User tests: Successful: Unsuccessful:
First PR of 2022 - Happy New Year..
Pull Request for Issue .. well countless issues.
Yes I know this is controversial ... but.. like @brianteeman says, its the real world verses the perfect world.
Implement a deprecated trait to the CMS Application to allow calls to isSite
and isAdmin
application methods for the Joomla 4 series.
you can now call $app->isSite()
or $app->isAdmin()
and get a bool
back
Some old extensions that did not pay attention to Joomla 4 development bombed out on missing methods.
A deprecated trait that allows the continued calling of these methods - but logs a deprecated message
Educate developers to NOT use this code in this PR ;-)
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Just because I wrote a PR, doesn't mean you have to merge it - you can reject it... :-) No hard feelings.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-02 08:59:26 |
Closed_By | ⇒ | Fedik |
Let me fix it
Thanks for try anyway ;)
Awesome, so this is a vote to move forward and not back, time to PR a deprecation of isClient
method next then ;-)
That sounds as a good plan ;)
I mean this is no less likely to get actioned than before in my opinion. Like I’ll leave it open so other maintainers can form an opinion. But this was deprecated clearly since 3.6. I don’t see leaving it until 5 as being better so? from me