? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
1 Jan 2022

First PR of 2022 - Happy New Year..

Pull Request for Issue .. well countless issues.

Yes I know this is controversial ... but.. like @brianteeman says, its the real world verses the perfect world.

Summary of Changes

Implement a deprecated trait to the CMS Application to allow calls to isSite and isAdmin application methods for the Joomla 4 series.

Testing Instructions

you can now call $app->isSite() or $app->isAdmin() and get a bool back

Actual result BEFORE applying this Pull Request

Some old extensions that did not pay attention to Joomla 4 development bombed out on missing methods.

Expected result AFTER applying this Pull Request

A deprecated trait that allows the continued calling of these methods - but logs a deprecated message

Documentation Changes Required

Educate developers to NOT use this code in this PR ;-)

avatar PhilETaylor PhilETaylor - open - 1 Jan 2022
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2022
Category Libraries
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jan 2022
e6503aa 1 Jan 2022 avatar PhilETaylor cs
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jan 2022
a3d13d9 1 Jan 2022 avatar PhilETaylor cs
avatar wilsonge
wilsonge - comment - 1 Jan 2022

I mean this is no less likely to get actioned than before in my opinion. Like I’ll leave it open so other maintainers can form an opinion. But this was deprecated clearly since 3.6. I don’t see leaving it until 5 as being better so ? from me

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Just because I wrote a PR, doesn't mean you have to merge it - you can reject it... :-) No hard feelings.

avatar Fedik Fedik - change - 2 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-02 08:59:26
Closed_By Fedik
avatar Fedik
Fedik - comment - 2 Jan 2022

Let me fix it ?

avatar Fedik Fedik - close - 2 Jan 2022
avatar Fedik
Fedik - comment - 2 Jan 2022

Thanks for try anyway ;)

avatar PhilETaylor
PhilETaylor - comment - 2 Jan 2022

Awesome, so this is a vote to move forward and not back, time to PR a deprecation of isClient method next then ;-)

avatar Fedik
Fedik - comment - 2 Jan 2022

That sounds as a good plan ;)

Add a Comment

Login with GitHub to post a comment