Feeling Lucky
?
?
NPM Resource Changed
[#36329] - [4.0] Handle when toggle icon is not available
- Fixed in Code Base
- 4 Jan 2022
- Medium
- Build: 4.0-dev
- # 36329
- Diff
- Digital-Peak:j4/mce/toggle
User tests: Successful: Unsuccessful:
Summary of Changes
The TinyMCE toggle button does not work when the icon element is not available.
Testing Instructions
- Put the following content into the file /templates/cassiopeia/html/layouts/joomla/tinymce/togglebutton.php:
<div class="toggle-editor btn-toolbar float-end clearfix mt-3"> <div class="btn-group"> <button type="button" disabled class="btn btn-secondary js-tiny-toggler-button"> <?php echo JText::_('PLG_TINY_BUTTON_TOGGLE_EDITOR'); ?> </button> </div> </div> - Edit an article on the front end
- Click on the toggle editor button
Actual result BEFORE applying this Pull Request
Javascript error in dev console of the browser:
Uncaught TypeError: toggleIcon is null
setupEditors http://joomla.box/cms4/media/plg_editors_tinymce/js/tinymce.js?7e502e51b417ca05bec2d8a8aa43adec:33
Expected result AFTER applying this Pull Request
No error and editor turns into textarea.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
jwaisner
- comment
- 3 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36329.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 3 Jan 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36329.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-04 00:32:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 4 Jan 2022
Thanks!
I have tested this item✅ successfully on 2dd9ed2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36329.