No Code Attached Yet
avatar Scrabble96
Scrabble96
16 Dec 2021

Problem identified

I have just updated a J4 site from 4.0.4 to 4.0.5 and have been notified of four overridden files.
One of these is a category blog override and I'm currently looking at blog_children.php.

Having double-checked with the source code here on Github, I can see that:

The copyright appears to have changed from
"* @copyright Copyright (C) 2005 - 2020 Open Source Matters, Inc. All rights reserved."
to
" * @copyright (C) 2010 Open Source Matters, Inc. https://www.joomla.org"

file-override-differences

and line 32 from
<span class="badge badge-info tip">
to
<span class="badge bg-info tip">

(Plus a few other changes).

I would have expected the new, 'correct' text or code to be highlighted green and the old, or 'wrong' text or code that needs changing, to be highlighted in pink.

Similarly, above the editor, in order to see the original file file, you have to click the grey button that says "Hide Original" and to see the differences, click the grey button "Hide Differences"

Proposed solution

  1. Swap the highlighting colours
  2. Switch the text so that it initially displays "Show Original" and "Show Differences"

Open questions

avatar Scrabble96 Scrabble96 - open - 16 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Dec 2021
avatar brianteeman
brianteeman - comment - 15 Aug 2022
  1. Traditionaly in a diff red is the original and green is the changed version. Hopefully if #38401 is merged it will remove any confusion
  2. As with all uses of a toggle button throughout joomla the text is showing the current state so your suggestion would be incorrect. However it would probably be better to change the label to "Show Differences" and the state to yes/no #38463
avatar joomdonation
joomdonation - comment - 14 Nov 2022

@brianteeman @Scrabble96 As I understand, after two PRs #38823 and #38463 merged, this issue is now solved. Could you please confirm so that we can close this issue?

avatar joomdonation joomdonation - change - 4 Dec 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-12-04 12:10:57
Closed_By joomdonation
avatar joomdonation joomdonation - close - 4 Dec 2022
avatar joomdonation
joomdonation - comment - 4 Dec 2022

Brian confirmed that the two PRs solved the issue, therefore, I'm closing this issue.

Add a Comment

Login with GitHub to post a comment