User tests: Successful: Unsuccessful:
Pull Request for Issue #36166 .
Changes to the content plugin emailcloak.php
Changes to the file joomla-hidden-mail.js under media/system/js
Reason: When setting the tag "joomla-hidden-mail" the class and style attributes are duplicated. Therefore I have them both removed from the tag.
A change to the core.js file
Here is the function sanitizeHtml. This had prevented that style specifications are not taken over with images. The attribute "style" was added to the allow list.
Include any of the following content with an email in an article. Examples are also in the source code of the "emailcloak" plugin
<p><a href="http://mce_host/ourdirectory/email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="http://mce_host/ourdirectory/email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">email@example.org</span></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">anytext</span></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" /></a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />email@example.org</a></p>
<p><a href="mailto:email@example.org" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />any text</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;">email@example.org</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;">anytext</a></p>
<p><a href="mailto:email@example.org?subject= Text" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">email@example.org</span></a></p>
<p><a href="mailto:email@example.org?subject= Text" class="btn btn-danger" style="border: 2px solid #f00;"><span class="test" style="text-transform: uppercase;">anytext</span></a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" /></a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />email@example.org</a></p>
<p><a href="mailto:email@example.org?subject=Text" class="btn btn-danger" style="border: 2px solid #f00;"><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" />any text</a></p>
<p><img src="images/joomla_black.png" alt="" class="img-thumbnail" style="border: 1px solid #00f;" title="email@example.org" /></p>
<p><input type="text" placeholder="email@example.org" /></p>
no changes
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
Title |
|
Labels |
Added:
?
NPM Resource Changed
|
@LukasHH
thanks for your examples.backend: OK.
wanted to test for frontend with prebuilt package. unfortunately can't reach github view (404) for installing prebuilt-package.
I have tested this item
OK, with automatic e-mail, I got now the prebuilt package via github.
Status | Pending | ⇒ | Ready to Commit |
RTC
Works for me! Great work, thanks!
I have tested this item
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Title |
|
For me this solves a lot of problems but the first example is broken. It should NOT display the email address at all, even though there is a link around. The email address has to be "cloaked" there too (without a mailto link)
Status | Ready to Commit | ⇒ | Pending |
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
Labels |
Added:
?
?
Removed: ? |
@bembelimen I will see that I can fix the last problem.
Labels |
Added:
?
Maintainers Checked
Removed: ? ? |
@chmst @ChristineWk @khu5h1 Could you test again? The PR has received some change due to a review comment. Thanks in advance.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
Removed: ? |
Title |
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-29 21:39:31 |
Closed_By | ⇒ | fancyFranci |
I have tested this item✅ successfully on 152b089
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36269.