? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
8 Dec 2021

Pull Request for Issue #36257 .

Summary of Changes

Change how a dummy module added when template preview is requested.

Testing Instructions

Please follow #36257

Actual result BEFORE applying this Pull Request

Not all positions is shown in preview mode

Expected result AFTER applying this Pull Request

All position is shown

Documentation Changes Required

None

avatar Fedik Fedik - open - 8 Dec 2021
avatar Fedik Fedik - change - 8 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2021
Category Libraries
avatar brianteeman
brianteeman - comment - 8 Dec 2021

image

avatar brianteeman brianteeman - test_item - 8 Dec 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 8 Dec 2021

I have tested this item ? unsuccessfully on ed1a749


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36268.

avatar Fedik Fedik - change - 9 Dec 2021
Labels Added: ?
avatar Fedik
Fedik - comment - 9 Dec 2021

One more time :)
Should be better now

avatar brianteeman brianteeman - test_item - 9 Dec 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Dec 2021

I have tested this item successfully on 2ef95e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36268.

avatar ChristineWk ChristineWk - test_item - 9 Dec 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 9 Dec 2021

I have tested this item successfully on 2ef95e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36268.

avatar alikon alikon - change - 9 Dec 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36268.

avatar khu5h1 khu5h1 - test_item - 14 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Dec 2021

I have tested this item successfully on 2ef95e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36268.

avatar wilsonge wilsonge - change - 8 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-08 20:40:00
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 8 Jan 2022
avatar wilsonge wilsonge - merge - 8 Jan 2022
avatar wilsonge
wilsonge - comment - 8 Jan 2022

Thanks!

avatar wilsonge
wilsonge - comment - 8 Jan 2022

Thanks for the review @zero-24 (verbally approved by google meet)

Add a Comment

Login with GitHub to post a comment