Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36267] - [4.0] Full Image class hint

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Dec 2021

Based on feedback and user requests this simple pr adds a hint for the type of class you can add in the image class for the full article image

cc @softforge

image

avatar brianteeman brianteeman - open - 8 Dec 2021
avatar brianteeman brianteeman - change - 8 Dec 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2021
Category ⇒ Administration com_content Language & Strings
avatar softforge
softforge - comment - 8 Dec 2021

Even those that know how to use classes can have a senior moment so such class hints are really helpful. Its a half way hose to the hard coded way we had in J3 that had left and right switch and the universal way to allow any styling to be added

avatar brianteeman
brianteeman - comment - 8 Dec 2021

please test and report results

avatar dgrammatiko
dgrammatiko - comment - 8 Dec 2021

@brianteeman could you add is also here

joomla-cms/build/media_source/system/js/fields/joomla-media-select.w-c.es6.js

Lines 408 to 411 in 7978f28

<div class="input-group">
<label class="input-group-text" for="${this.parentId}-classes">${this.classestext}</label>
<input class="form-control" type="text" id="${this.parentId}-classes" data-is="img-classes"/>
</div>

Something like

    <div class="input-group">
      <label class="input-group-text" for="${this.parentId}-classes">${this.classestext}</label>
      <input class="form-control" type="text" id="${this.parentId}-classes" data-is="img-classes"/>
      <small for="${this.parentId}-classes">${Joomla.Text._('JLIB_FORM_MEDIA_IMAGE_CLASS_DESC')}</small>
    </div>

and adding the text here

joomla-cms/layouts/joomla/form/field/media.php

Line 143 in 7978f28

Text::script('JLIB_FORM_MEDIA_PREVIEW_EMPTY', true);
like

Text::script('JLIB_FORM_MEDIA_IMAGE_CLASS_DESC', true);

BTW the text needs to be in the joomla.ini

avatar brianteeman
brianteeman - comment - 8 Dec 2021

@dgrammatiko I will do that in a separate pr

avatar ChristineWk ChristineWk - test_item - 9 Dec 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 9 Dec 2021

I have tested this item ✅ successfully on 1b57e8b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267.

avatar chmst chmst - test_item - 10 Dec 2021 - Tested successfully
avatar chmst
chmst - comment - 10 Dec 2021

I have tested this item ✅ successfully on 1b57e8b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267.

avatar chmst chmst - change - 10 Dec 2021
Status Pending ⇒ Ready to Commit
avatar chmst
chmst - comment - 10 Dec 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267.

avatar khu5h1 khu5h1 - test_item - 14 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Dec 2021

I have tested this item ✅ successfully on 1b57e8b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36267.

avatar Quy Quy - change - 28 Dec 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-12-28 22:09:05
Closed_By ⇒ Quy
Labels Added: ? ?
avatar Quy Quy - close - 28 Dec 2021
avatar Quy Quy - merge - 28 Dec 2021
avatar Quy
Quy - comment - 28 Dec 2021

Thanks

Add a Comment

Login with GitHub to post a comment