? ? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
8 Dec 2021

See title

avatar HLeithner HLeithner - open - 8 Dec 2021
avatar HLeithner HLeithner - change - 8 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2021
Category Unit Tests
avatar HLeithner HLeithner - change - 8 Dec 2021
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 8 Dec 2021

For unknown reason media manager fails...

avatar Fedik
Fedik - comment - 8 Dec 2021

I think it may be due to ajax request fail,
I see there many deprecate notices, one of them could break the body of ajax response

avatar HLeithner
HLeithner - comment - 8 Dec 2021

it also fails with 7.2 (phpmin) (with the new images, not sure if the last update changed anything since the last build)

avatar wilsonge
wilsonge - comment - 11 Dec 2021

Updated this branch a few times as I've merged in some of the 8.1 fixes in case.

avatar wilsonge
wilsonge - comment - 13 Dec 2021

The test fail is super weird. It creates a new folder (NOT via the UI - but by a PHP function (which is also used to create the test-dir that all the tests work from - so it must work)). Then it goes to the UI and tries to rename the folder. But the new sub-folder created doesn't show up in the UI - so it can't rename it and so fails.

FWIW I can confirm that this specific test does work in PHP 8.1 too on my local setup :)

avatar wilsonge
wilsonge - comment - 14 Dec 2021

No figured it out. You changed the install directory to be db folder specific but didn't update https://github.com/joomla/joomla-cms/pull/36260/files#diff-d43be3f113ad505ac2e42c4da89933bbd1e25cee518586ecbf04156bcae55144R44 @HLeithner - just needs that overriding for each DB type now

1b0d401 14 Dec 2021 avatar HLeithner debug
501ed03 14 Dec 2021 avatar HLeithner debug
d7d5792 14 Dec 2021 avatar HLeithner debug
fa517ad 14 Dec 2021 avatar HLeithner debug
avatar wilsonge
wilsonge - comment - 16 Dec 2021

@HLeithner still a bit ugly - but this works

avatar wilsonge
wilsonge - comment - 17 Dec 2021

Screenshot 2021-12-17 at 00 17 58

The current test fail matches my local setup results for PHP 8.1 - so I'd say this is now "working as expected"

avatar HLeithner
HLeithner - comment - 17 Dec 2021

At least it works. The deprecation should be fixed before we merge this ;-)

avatar wilsonge
wilsonge - comment - 20 Dec 2021

Can you add an allowed fail for the phpmax system tests? I'd like to get this in and then I can start crossing failures out directly with system test proof

avatar HLeithner
HLeithner - comment - 22 Dec 2021

@wilsonge tests are working now, I also added api tests for postgres and it seems it fails because of a bug https://ci.joomla.org/joomla/joomla-cms/49383/1/27

maybe @richard67 or @alikon can have a look?

I would merge it now and fix es problems later and remove the failure ignore when fixed.

avatar alikon
alikon - comment - 22 Dec 2021

yes please merge this now
we can fix postgresql issues later
if not by these

avatar HLeithner HLeithner - change - 22 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-22 18:29:25
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 22 Dec 2021
avatar HLeithner HLeithner - merge - 22 Dec 2021
avatar PhilETaylor
PhilETaylor - comment - 24 Dec 2021

I have done a round of fixes tonight, in Joomla-cms Joomla-framework/database and in the unit tests... merge all those and most of the tests will run without deprecated messages

Add a Comment

Login with GitHub to post a comment