? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
8 Dec 2021

Pull Request for Issue #36254.

Summary of Changes

Adds proper classes to the search bar layout description element. Additionally it simplifies the code and adds some more classes in BEM style to the other elements.

History:

Testing Instructions

Go to any search toolbar in the backend and inspect the search field.

Actual result BEFORE applying this Pull Request

Renders properly.

Expected result AFTER applying this Pull Request

Renders properly but has new CSS classes.

avatar laoneo laoneo - open - 8 Dec 2021
avatar laoneo laoneo - change - 8 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Dec 2021
Category Repository NPM Change Layout
avatar Quy Quy - test_item - 9 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 9 Dec 2021

I have tested this item successfully on a3d6815


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36259.

avatar BertaOctech BertaOctech - test_item - 10 Dec 2021 - Tested successfully
avatar BertaOctech
BertaOctech - comment - 10 Dec 2021

I have tested this item successfully on a3d6815

It works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36259.

avatar alikon alikon - change - 10 Dec 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 10 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36259.

avatar khu5h1 khu5h1 - test_item - 14 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Dec 2021

I have tested this item successfully on a3d6815


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36259.

avatar bembelimen bembelimen - change - 16 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-16 12:02:39
Closed_By bembelimen
Labels Added: ? NPM Resource Changed ?
avatar bembelimen bembelimen - close - 16 Dec 2021
avatar bembelimen bembelimen - merge - 16 Dec 2021
avatar bembelimen
bembelimen - comment - 16 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment