Joomla! Issue Tracker | Joomla! CMS #36261 - Remove hard-limit of 20 to the Module Tags

? ?

Closed
18 Jan 2022
Medium
Build: 4.0-dev
# 36261
Diff
Shubhamverma2796:issue_36016

Pending

User tests: Successful: Unsuccessful:

Shubhamverma2796
8 Dec 2021

Pull Request for Issue #36016.

Summary of Changes

Removed the hard limit for Module Tags-Popular and Module Tags-Similar.

Testing Instructions

Site modules--> New-->Tags-Popular.
Set the maximum tags to a number > 20 and make sure that the tags are displayed correctly in the frontend.

Actual result BEFORE applying this Pull Request

see #36016

Expected result AFTER applying this Pull Request

Any number is possible.

Documentation Changes Required

9118237 8 Dec 2021

Remove hard-limit of 20 to the Module Tags

Shubhamverma2796 - open - 8 Dec 2021

Shubhamverma2796 - change - 8 Dec 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 8 Dec 2021

Category

⇒

Modules Front End

ChristineWk - test_item - 8 Dec 2021 - Tested successfully

ChristineWk - comment - 8 Dec 2021

I have tested this item ✅ successfully on 9118237

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

Ravi-chandra69 - test_item - 8 Dec 2021 - Tested successfully

Ravi-chandra69 - comment - 8 Dec 2021

I have tested this item ✅ successfully on 9118237

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

3d9114a 8 Dec 2021

changed the min value

Shubhamverma2796 - change - 8 Dec 2021

Labels

Added: ?

ChristineWk - test_item - 8 Dec 2021 - Tested successfully

ChristineWk - comment - 8 Dec 2021

I have tested this item ✅ successfully on 3d9114a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

d214575 8 Dec 2021

Update modules/mod_tags_popular/src/Helper/TagsPopularHelper.php

Shubhamverma2796 - comment - 8 Dec 2021

@richard67 I've made the required changes but still, the build is failing by saying white space found at the end of the line. But 163 is an empty line. Please help me to resolve this issue.

323e5d4 8 Dec 2021

removed space

6a25c82 8 Dec 2021

Merge branch 'issue_36016' of https://github.com/Shubhamverma2796/joomla-cms into issue_36016

1809e6a 8 Dec 2021

added a new line at the end of the file

Shubhamverma2796 - comment - 8 Dec 2021

@ChristineWk @Ravi-chandra69 Finally the build is successful. Could you guys please test it again? Sorry for the repetitive work and thanks in advance.

Ravi-chandra69 - test_item - 8 Dec 2021 - Tested successfully

Ravi-chandra69 - comment - 8 Dec 2021

I have tested this item ✅ successfully on 1809e6a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

ChristineWk - comment - 8 Dec 2021

even after re-fetching data, then applied again with patchtester, got response:
The patch could not be applied because it conflicts with a previously applied patch: modules/mod_tags_popular/mod_tags_popular.xml
maybe I could try on another test-site.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

ChristineWk - test_item - 8 Dec 2021 - Tested successfully

ChristineWk - comment - 8 Dec 2021

I have tested this item ✅ successfully on 1809e6a

on another site.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

ChristineWk - comment - 8 Dec 2021

I have tested this item ✅ successfully on 1809e6a

on another site.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

73ff13e 10 Dec 2021

Update modules/mod_tags_similar/src/Helper/TagsSimilarHelper.php

Shubhamverma2796 - change - 10 Dec 2021

Labels

Added: ?

042dd1c 10 Dec 2021

Update modules/mod_tags_popular/mod_tags_popular.xml

9b31347 10 Dec 2021

Update modules/mod_tags_similar/src/Helper/TagsSimilarHelper.php

Ravi-chandra69 - test_item - 10 Dec 2021 - Tested successfully

Ravi-chandra69 - comment - 10 Dec 2021

I have tested this item ✅ successfully on 9b31347

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

Ravi-chandra69 - comment - 10 Dec 2021

I have tested this item ✅ successfully on 9b31347

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

pabloarias - test_item - 10 Dec 2021 - Tested unsuccessfully

pabloarias - comment - 10 Dec 2021

I have tested this item ? unsuccessfully on 9b31347

Hello:

I've tested the path in Joomla 4.0.5-rc4, PHP version 8.0.

When I apply the path, it breaks the entire site: "The requested page can't be found". Here it gives a clue:

call_user_func_array(): Argument #1 ($function) must be a valid callback, class "Joomla\Module\TagsSimilar\Site\Helper\TagsSimilarHelper" not found

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

chmst - comment - 10 Dec 2021

@pabloarias I can test the patch without errors. This times I used the patchtester component. But on php 7.4. So maybe it is the php version?

How did you apply the patch? Could you please set debug-modus on and error-reporting maximum?

N6REJ - comment - 12 Dec 2021

I have tested this item ? unsuccessfully on 9b31347Hello:

I've tested the path in Joomla 4.0.5-rc4, PHP version 8.0.

When I apply the path, it breaks the entire site: "The requested page can't be found". Here it gives a clue:

call_user_func_array(): Argument #1 ($function) must be a valid callback, class "Joomla\Module\TagsSimilar\Site\Helper\TagsSimilarHelper" not found

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.

If your going to test with php 8 please make sure its 8.0.13
or newer

infograf768 - comment - 12 Dec 2021

php 8.0.8 is fine here.

N6REJ - comment - 12 Dec 2021

php 8.0.8 is fine here.

thanks jm.. I knew php 8.0.0 had issues but the only other one "I" have is 8.0.13
Glad to see you again. Merry Christmas

pabloarias - comment - 13 Dec 2021

Oops, I tested it with PHP version 8.0.7.

I used Path Tester too to apply the path.

N6REJ - comment - 13 Dec 2021

Oops, I tested it with PHP version 8.0.7.

I used Path Tester too to apply the path.

do you actually have 21 or more tags?

pabloarias - comment - 13 Dec 2021

Yes. I installed blog example content and created more than 21 tags to test this path.

N6REJ - test_item - 13 Dec 2021 - Tested unsuccessfully

N6REJ - comment - 13 Dec 2021

I have tested this item ? unsuccessfully on 9b31347

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

php: 8.0.13
apache: 2.4.51

Started w/o patchtester and confirmed max is 20.

Ran the following in phpmyadmin 5.1.1

INSERT INTO `cjtkb_tags` (`id`, `parent_id`, `lft`, `rgt`, `level`, `path`, `title`, `alias`, `note`, `description`, `published`, `checked_out`, `checked_out_time`, `access`, `params`, `metadesc`, `metakey`, `metadata`, `created_user_id`, `created_time`, `created_by_alias`, `modified_user_id`, `modified_time`, `images`, `urls`, `hits`, `language`, `version`, `publish_up`, `publish_down`) VALUES
(6 , 4, 6, 7, 2, 'love', 'love', 'love', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(7 , 4, 6, 7, 2, 'instagood', 'instagood', 'instagood', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(8 , 4, 6, 7, 2, 'photooftheday', 'photooftheday', 'photooftheday', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(9 , 4, 6, 7, 2, 'beautiful', 'beautiful', 'beautiful', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(10 , 4, 6, 7, 2, 'fashion', 'fashion', 'fashion', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(11 , 4, 6, 7, 2, 'tbt', 'tbt', 'tbt', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(12 , 4, 6, 7, 2, 'happy', 'happy', 'happy', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(13 , 4, 6, 7, 2, 'cute', 'cute', 'cute', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(14 , 4, 6, 7, 2, 'followme', 'followme', 'followme', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(15 , 4, 6, 7, 2, 'like4like', 'like4like', 'like4like', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(16 , 4, 6, 7, 2, 'follow', 'follow', 'follow', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(17 , 4, 6, 7, 2, 'me', 'me', 'me', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(18 , 4, 6, 7, 2, 'picoftheday', 'picoftheday', 'picoftheday', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(19 , 4, 6, 7, 2, 'selfie', 'selfie', 'selfie', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(20 , 4, 6, 7, 2, 'instadaily', 'instadaily', 'instadaily', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(21 , 4, 6, 7, 2, 'friends', 'friends', 'friends', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(22 , 4, 6, 7, 2, 'summer', 'summer', 'summer', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(23 , 4, 6, 7, 2, 'girl', 'girl', 'girl', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(24 , 4, 6, 7, 2, 'art', 'art', 'art', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(25 , 4, 6, 7, 2, 'fun', 'fun', 'fun', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(26 , 4, 6, 7, 2, 'repost', 'repost', 'repost', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(27 , 4, 6, 7, 2, 'smile', 'smile', 'smile', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(28 , 4, 6, 7, 2, 'nature', 'nature', 'nature', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(29 , 4, 6, 7, 2, 'instalike', 'instalike', 'instalike', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(30 , 4, 6, 7, 2, 'food', 'food', 'food', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(31 , 4, 6, 7, 2, 'style', 'style', 'style', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(32 , 4, 6, 7, 2, 'tagsforlikes', 'tagsforlikes', 'tagsforlikes', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(33 , 4, 6, 7, 2, 'family', 'family', 'family', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(34 , 4, 6, 7, 2, 'likeforlike', 'likeforlike', 'likeforlike', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(35 , 4, 6, 7, 2, 'igers', 'igers', 'igers', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(36 , 4, 6, 7, 2, 'fitness', 'fitness', 'fitness', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(37 , 4, 6, 7, 2, 'nofilter', 'nofilter', 'nofilter', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(38 , 4, 6, 7, 2, 'follow4follow', 'follow4follow', 'follow4follow', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(39 , 4, 6, 7, 2, 'instamood', 'instamood', 'instamood', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(40 , 4, 6, 7, 2, 'amazing', 'amazing', 'amazing', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(41 , 4, 6, 7, 2, 'life', 'life', 'life', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(42 , 4, 6, 7, 2, 'travel', 'travel', 'travel', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(43 , 4, 6, 7, 2, 'beauty', 'beauty', 'beauty', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(44 , 4, 6, 7, 2, 'vscocam', 'vscocam', 'vscocam', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(45 , 4, 6, 7, 2, 'sun', 'sun', 'sun', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(46 , 4, 6, 7, 2, 'bestoftheday', 'bestoftheday', 'bestoftheday', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(47 , 4, 6, 7, 2, 'music', 'music', 'music', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(48 , 4, 6, 7, 2, 'followforfollow', 'followforfollow', 'followforfollow', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(49 , 4, 6, 7, 2, 'beach', 'beach', 'beach', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(50 , 4, 6, 7, 2, 'instagram', 'instagram', 'instagram', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(51 , 4, 6, 7, 2, 'photo', 'photo', 'photo', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(52 , 4, 6, 7, 2, 'sky', 'sky', 'sky', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(53 , 4, 6, 7, 2, 'vsco', 'vsco', 'vsco', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(54 , 4, 6, 7, 2, 'dog', 'dog', 'dog', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(55 , 4, 6, 7, 2, 'l4l', 'l4l', 'l4l', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(56 , 4, 6, 7, 2, 'sunset', 'sunset', 'sunset', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(57 , 4, 6, 7, 2, 'f4f', 'f4f', 'f4f', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(58 , 4, 6, 7, 2, 'ootd', 'ootd', 'ootd', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(59 , 4, 6, 7, 2, 'pretty', 'pretty', 'pretty', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(60 , 4, 6, 7, 2, 'swag', 'swag', 'swag', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(61 , 4, 6, 7, 2, 'makeup', 'makeup', 'makeup', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(62 , 4, 6, 7, 2, 'foodporn', 'foodporn', 'foodporn', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(63 , 4, 6, 7, 2, 'hair', 'hair', 'hair', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(64 , 4, 6, 7, 2, 'cat', 'cat', 'cat', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(65 , 4, 6, 7, 2, 'party', 'party', 'party', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(66 , 4, 6, 7, 2, 'girls', 'girls', 'girls', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(67 , 4, 6, 7, 2, 'photography', 'photography', 'photography', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(68 , 4, 6, 7, 2, 'cool', 'cool', 'cool', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(69 , 4, 6, 7, 2, 'baby', 'baby', 'baby', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(70 , 4, 6, 7, 2, 'lol', 'lol', 'lol', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(71 , 4, 6, 7, 2, 'tflers', 'tflers', 'tflers', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(72 , 4, 6, 7, 2, 'model', 'model', 'model', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(73 , 4, 6, 7, 2, 'motivation', 'motivation', 'motivation', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(74 , 4, 6, 7, 2, 'night', 'night', 'night', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(75 , 4, 6, 7, 2, 'instapic', 'instapic', 'instapic', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(76 , 4, 6, 7, 2, 'funny', 'funny', 'funny', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(77 , 4, 6, 7, 2, 'gym', 'gym', 'gym', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(78 , 4, 6, 7, 2, 'healthy', 'healthy', 'healthy', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(79 , 4, 6, 7, 2, 'yummy', 'yummy', 'yummy', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(80 , 4, 6, 7, 2, 'hot', 'hot', 'hot', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(81 , 4, 6, 7, 2, 'design', 'design', 'design', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(82 , 4, 6, 7, 2, 'black', 'black', 'black', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(83 , 4, 6, 7, 2, 'pink', 'pink', 'pink', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(84 , 4, 6, 7, 2, 'flowers', 'flowers', 'flowers', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(85 , 4, 6, 7, 2, 'christmas', 'christmas', 'christmas', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(86 , 4, 6, 7, 2, 'blue', 'blue', 'blue', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(87 , 4, 6, 7, 2, 'work', 'work', 'work', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(88 , 4, 6, 7, 2, 'instafood', 'instafood', 'instafood', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(89 , 4, 6, 7, 2, 'fit', 'fit', 'fit', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(90 , 4, 6, 7, 2, 'instacool', 'instacool', 'instacool', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(91 , 4, 6, 7, 2, 'iphoneonly', 'iphoneonly', 'iphoneonly', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(92 , 4, 6, 7, 2, 'wedding', 'wedding', 'wedding', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(93 , 4, 6, 7, 2, 'blackandwhite', 'blackandwhite', 'blackandwhite', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(94 , 4, 6, 7, 2, 'workout', 'workout', 'workout', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(95 , 4, 6, 7, 2, 'lifestyle', 'lifestyle', 'lifestyle', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(96 , 4, 6, 7, 2, 'handmade', 'handmade', 'handmade', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(97 , 4, 6, 7, 2, 'followback', 'followback', 'followback', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(98 , 4, 6, 7, 2, 'instafollow', 'instafollow', 'instafollow', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(99 , 4, 6, 7, 2, 'home', 'home', 'home', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(100, 4, 6, 7, 2, 'drawing', 'drawing', 'drawing', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(101, 4, 6, 7, 2, 'my', 'my', 'my', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(102, 4, 6, 7, 2, 'nyc', 'nyc', 'nyc', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(103, 4, 6, 7, 2, 'webstagram', 'webstagram', 'webstagram', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(104, 4, 6, 7, 2, 'sweet', 'sweet', 'sweet', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL),
(105, 4, 6, 7, 2, 'instalove', 'instalove', 'instalove', '', '', 1, NULL, NULL, 1, '{}', '', '', '{}', 766, '2021-11-23 18:13:49', '', 766, '2021-11-23 18:13:49', '{}', '{}', 0, '*', 4, NULL, NULL);

ran patchtester to apply the patch.

Then followed the instructions to create a new module with limit set to 250

was on home page prior to saving module.
after reload I got ...

The issue appears to be in the pathing. Looks like the namespace is incorrect in mod_tags_similar.xml. ( current pull )

richard67 - comment - 13 Dec 2021

@N6REJ The left and right values in your insert statements are all the same. Maybe this causes the problems in your tests? The tags table is a nested set table where the lft and rgt values form a hierarchical tree, like in categories or menus or assets tables.

Shubhamverma2796 - comment - 22 Dec 2021

@richard67 I am not unable to find the reason why the patch is failing for some people. Please help.

richard67 - comment - 22 Dec 2021

@richard67 I am not unable to find the reason why the patch is failing for some people. Please help.

@Shubhamverma2796 "not unable"? I guess you mean either "not able" or "unable".

I don't think I can help much here.

Shubhamverma2796 - comment - 22 Dec 2021

@richard67 I am not unable to find the reason why the patch is failing for some people. Please help.

@Shubhamverma2796 "not unable"? I guess you mean either "not able" or "unable".

I don't think I can help much here.

it was a typing mistake. I will try to find the solution.

a3e935e 3 Jan 2022

Merge branch 'joomla:4.0-dev' into issue_36016

Shubhamverma2796 - change - 3 Jan 2022

Labels

Removed: ?

f9516bb 4 Jan 2022

Update modules/mod_tags_similar/src/Helper/TagsSimilarHelper.php

ditsuke - comment - 4 Jan 2022

I have tested this item ✅ successfully on f9516bb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

php: 7.4

Unfortunately, I was unable to test with php 8.x but I caught some issues that did not show up before. On a thorough review I was unable to find a reason for the callback failure. Future testers should test again with 8.x.

ditsuke - test_item - 4 Jan 2022 - Tested successfully

Shubhamverma2796 - comment - 4 Jan 2022

@pabloarias Can you please test it again? Thanks in advance.

pabloarias - comment - 14 Jan 2022

Hello:

I've updated PHP to version 8.0.10. It was not easy inside Devilbox but... trying to install the path with Path Tester 4.1.0 I obtain this message:

The patch could not be applied because the repository is missing.

Do you know why?

Thank you and best regards

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36261.}

richard67 - comment - 14 Jan 2022

The patch could not be applied because the repository is missing.

Do you know why?

It seems @Shubhamverma2796 has deleted his fork or his branch.

Shubhamverma2796 - comment - 14 Jan 2022

Sorry for the inconvenience everyone. I am closing this pr and I will make a new pr. I deleted the branch by mistake.

ditsuke - comment - 15 Jan 2022

Sorry for the inconvenience everyone. I am closing this pr and I will make a new pr. I deleted the branch by mistake.

@Shubhamverma2796 you can recover your branch and let this PR stay

Shubhamverma2796 - comment - 18 Jan 2022

please test #36732. I'm closing this pr.

Shubhamverma2796 - close - 18 Jan 2022

Shubhamverma2796 - change - 18 Jan 2022

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-01-18 13:47:23
Closed_By		⇒	Shubhamverma2796
Labels	Added: ?

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#36261] - Remove hard-limit of 20 to the Module Tags

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Add a Comment