? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Dec 2021

Pull Request for Issue # .

Summary of Changes

Fixes this:

<script>window.errorLocale={};</script><!-- Sets the content of the translated text, IMPORTANT DO NOT REMOVE -->

Testing Instructions

  • run node ./build/build.js --build-pages
  • and check the file: templates/system/incompatible.html

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No

avatar dgrammatiko dgrammatiko - open - 5 Dec 2021
avatar dgrammatiko dgrammatiko - change - 5 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2021
Category JavaScript Repository
avatar HLeithner
HLeithner - comment - 6 Dec 2021

@wilsonge error in the error pages^^

avatar richard67
richard67 - comment - 6 Dec 2021

@dgrammatiko Npm repotrs a syntax error here https://ci.joomla.org/joomla/joomla-cms/48988/1/7 :

/********/src/build/build-modules-js/error-pages.es6.js:47
    if (languageStrings.BUILD_MIN_PHP_ERROR_LANGUAGE)) {
avatar dgrammatiko dgrammatiko - change - 6 Dec 2021
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 6 Dec 2021

@richard67 i can’t copy paste…

avatar wilsonge wilsonge - change - 6 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-06 22:03:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Dec 2021
avatar wilsonge wilsonge - merge - 6 Dec 2021
avatar wilsonge
wilsonge - comment - 6 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment