[#36221] - [4.0][bugfix] Fix Figure misbehaviour in tinyMCE
- Fixed in Code Base
- 21 Dec 2021
- Medium
- Build: 4.0-dev
- # 36221
- Diff
- dgrammatiko:patch-11
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue, sorry couldn't found the one...
Summary of Changes
- Adds a class
imageto thefigureelement as tinyMCE expects that to enable the editing of thefigcaptiontext
Testing Instructions
This Pr needs NPM
- Fetch and run npm install
- Try to select an image using the Joomla dropdown icon and then selecting media
- Add some figure class and some text for the figure caption
- You should have a boxed area around the image and clicking in the caption text you should be able to edit it
Actual result BEFORE applying this Pull Request
Editing a figure element is kinda broken
Expected result AFTER applying this Pull Request
Editing a figure element is easier
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
NPM Resource Changed
|
||
@dgrammatiko nice and simple. If I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.
if I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.
Do you mean something like:
<!-- before -->
<figure>
<figcaption>
<img ... >
</figure>
<!-- after -->
<figure>
<img ... >
<figcaption>
</figure>TBH I had to check MDN as I had the impression that figcaption could only go as the last element of the figcaption, and clearly, that's not what the specs say: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption. Give me some time to think how that could be done
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
@brianteeman what failed here?
oops sorry I meant to change it to untested
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
tested correctly now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.
if I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.
Do you mean something like:
<!-- before --> <figure> <figcaption> <img ... > </figure> <!-- after --> <figure> <img ... > <figcaption> </figure>TBH I had to check MDN as I had the impression that
figcaptioncould only go as the last element of thefigcaption, and clearly, that's not what the specs say: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption. Give me some time to think how that could be done
ty, thats exactly what I meant. I appreciate you doing the extra effort
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-21 00:41:50 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on c54a3fe
Works exactly as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.</sub