Feeling Lucky
?
NPM Resource Changed
[#36195] - [4.0] Fix show password icon in login forms #36104
- Closed
- 5 Dec 2021
- Medium
- Build: 4.0-dev
- # 36195
- Diff
- AJAY007L:debugging
User tests: Successful: Unsuccessful:
Pull Request for Issue #36104.
Summary of Changes
In short, This PR makes the show password icon to icon-eye-slash, when the password is not visible and the show
password icon changes to icon-eye, when the password is visible.
Testing Instructions
see login form on
1. http://localhost/joomla-cms/administrator/ .
2. http://localhost/joomla-cms/.
3. http://localhost/joomla-cms/index.php/login (after installing sample data).
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None.
Note
This PR made changes on
1. http://localhost/joomla-cms/administrator/ login form.
2. http://localhost/joomla-cms/ login form.
3. http://localhost/joomla-cms/index.php/login login form.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Modules JavaScript Repository NPM Change Layout Front End |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-05 04:29:44 |
| Closed_By | ⇒ | AJAY007L | |
| Labels |
Added:
?
NPM Resource Changed
|
||
For me this is a pointless change. From a straw poll of two sites they both use opposite options. If its changed here now then people will be quite right to submit a pr to reverse it again with the same reasoning. its one of those where 50% of the people will always think its wrong
Twitter
Facebook