? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
4 Dec 2021

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the lists of files and folders to be deleted on update in file "administrator/components/com_admin/script.php" for 4.1.

In detail it changes following on the list of files:

  • Remove file "administrator/templates/atum/scss/pages/_com_joomlaupdate.scss" from the list in line 5951 as it appears later again in the list here: https://github.com/richard67/joomla-cms/blob/b9185a9eff0bbea116706ffd32d1ff6c1b4902aa/administrator/components/com_admin/script.php#L6172
    This is due to the file having been removed and later added back again in the 4.0-dev branch and now in the 4.1-dev branch it is removed again due to the child template changes.
    For details see the description of the recently merged PR #36161 .
  • Move section "// From 4.0.4 to 4.0.5" with file "media/vendor/codemirror/lib/#codemirror.js#" to the right place before section for 4.1.
  • Change comment of section for 4.1 from "// From 4.0.4 to 4.1.0" to "// From 4.0.5 to 4.1.0".

For the list of folders only the comment of section for 4.1 is changed from "// From 4.0.4 to 4.1.0" to "// From 4.0.5 to 4.1.0".

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

  • File "administrator/templates/atum/scss/pages/_com_joomlaupdate.scss" is 1 time in the list.
  • Order of sections and section comments are right.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 4 Dec 2021
avatar richard67 richard67 - change - 4 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2021
Category Administration com_admin
avatar richard67 richard67 - change - 4 Dec 2021
The description was changed
avatar richard67 richard67 - edited - 4 Dec 2021
avatar khu5h1
khu5h1 - comment - 4 Dec 2021

I have tested this item successfully on b9185a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

avatar khu5h1 khu5h1 - test_item - 4 Dec 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 5 Dec 2021

I have tested this item successfully on b9185a9

Tested by code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

avatar RickR2H RickR2H - test_item - 5 Dec 2021 - Tested successfully
avatar RickR2H RickR2H - change - 5 Dec 2021
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 5 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

avatar dgrammatiko
dgrammatiko - comment - 5 Dec 2021

@richard67 just out of curiosity how/when did the file /media/vendor/codemirror/lib/#codemirror.js# was created?

avatar bembelimen bembelimen - change - 5 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-05 18:22:00
Closed_By bembelimen
Labels Added: ? ?
avatar bembelimen bembelimen - close - 5 Dec 2021
avatar bembelimen bembelimen - merge - 5 Dec 2021
avatar bembelimen
bembelimen - comment - 5 Dec 2021

Thx

avatar richard67
richard67 - comment - 5 Dec 2021

@richard67 just out of curiosity how/when did the file /media/vendor/codemirror/lib/#codemirror.js# was created?

@dgrammatiko No idea about the "how". The "when" is 4.0.4, i.e. it was in the full package for 4.0.4 but not in previous ones. After the last Codemirror update it has disappeared from the sources.

avatar dgrammatiko
dgrammatiko - comment - 5 Dec 2021

The "when" is 4.0.4, i.e. it was in the full package for 4.0.4 but not in previous ones. After the last Codemirror update it has disappeared from the sources.

I'm asking because the build tools might be failing (probably on windows). I guess this needs some investigation...

Add a Comment

Login with GitHub to post a comment