Feeling Lucky
?
[#36193] - Fix Progressive caching to cache modules per custom menu assignment
- Fixed in Code Base
- 8 Jan 2022
- Medium
- Build: 4.0-dev
- # 36193
- Diff
- Fedik:cache-fix-progr
User tests: Successful: Unsuccessful:
Pull Request for Issue #36102 .
Summary of Changes
Progressive caching caches the modules per position, however this breaks custom menu assignment for module.
I have add Itemid to cache key for Progressive caching, so it works correctly now.
The same issue is for Joomla 3, can be back-ported if this PR is okay.
Testing Instructions
Apply patch.
Create a custom module, and assign to one specific menu.
Enable Progressive caching, and visit that menu, then visit other pages.
Actual result BEFORE applying this Pull Request
The module visible on all pages.
Expected result AFTER applying this Pull Request
The module visible only on selected page.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-08 20:40:47 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 8 Jan 2022
Thanks!
I have tested this item✅ successfully on 6100906
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36193.