[#36092] - Increase the usage of expressions with combined operators
- Closed
- 9 Aug 2022
- Medium
- Build: 4.2-dev
- # 36092
Would you like to integrate anything from a transformation result which can be generated by a command like the following?
(
lokal> perl -p -i.orig -0777 -e 's#(?<target>\$\S+)\s*=\s*\k<target>[ \t]*(?<operator>[+/%^.]|-(?!>)|&(?!&)|\|(?!\|)|\*\*?|<<|>>|\?\?)#$+{target} $+{operator}=#gm' $(find ~/Aktivitäten/Joomla/lokal -name '*.php')
alikon
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-09 16:05:43 |
| Closed_By | ⇒ | alikon |
I would appreciate a more constructive feedback for proposed change possibilities.
I would appreciate a more constructive feedback for proposed change possibilities.
You are free, like everyone in the world, to provide PRs with code changes and testing instructions that others can review and test. Sometimes code reviews are sufficient, sometimes not.
If you come along with 500 changes in 48 extensions and/or libraries in 1 pr there is little chance that anyone will spend their time on it.
Likewise, the code that comes out of it should also be halfway understandable, which is not always the case with blindly used, bitwise operators, e.g. in an if(); just because it is so fancy to use one.
In short: Start and provide PRs if you think it's worth it! And others will think about if this or that change is worth it because it is an optimization and not just a change.
Forgotten: And the changes must match the minimum PHP requirements of Joomla version.
Do you understand anything from the mentioned source code transformation approach (which could be performed also with the help of the shown Perl command example)?
As I've said: You cannot expect the result of a command line to be blindly merged into the Joomla core. And no one will spend their time testing all the changes made by it. So: Smaller steps are preferred. No untestable giant actions.
Do you understand anything from the mentioned source code transformation approach
I do, my friend. But again: To let people understand it you have to provide the results as readable PHP code as PRs to a Joomla branch.
You cannot expect the result of a command line to be blindly merged into the Joomla core.
I do not expect such an action.
? I am just looking for a better indication of the potential for change acceptance.
From the level of information provided - zero
This issue should be closed for obvious reasons