[#36094] - [4.0] Recreate namespace map on Joomla! update
- Fixed in Code Base
- 25 Nov 2021
- Medium
- Build: 4.0-dev
- # 36094
- Diff
- joomdonation:recreate_namespace_map_on_joomlaupdate
User tests: Successful: Unsuccessful:
Pull Request for Issue #36089.
Summary of Changes
This PR makes small modification to update Joomla! process so that namespace map is re-generated during Joomla! update. It is needed because when we update to new Joomla version which has new extension added, we need to register namespace of that new extension so that it can work properly.
Testing Instructions
- Apply patch from this PR
- Download the this update package Joomla_4.1.0-dev+pr.35143-Development-Update_Package.zip. I had to modify original update package for this PR #35143 (which introduces new extension for Joomla 4.1) to include the change from this PR so that update process runs smooth.
- Go to System -> Update -> Joomla, upload and update your Joomla 4 installation with the above downloaded package. Make sure you do not see any error with the update process.
Actual result BEFORE applying this Pull Request
Without the change from this PR, updating your site to the update package of this PR #35143 will cause a fatal error:
0 Class 'Joomla\Component\Scheduler\Administrator\Extension\SchedulerComponent' not found
Expected result AFTER applying this Pull Request
Update success. Namespace for new extension is successfully registered in administrator/cache/autoload_psr4.php.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
Is a Updater update needed? so if someone updates from 4.0.4 to 4.1 it will still crash?
I would not make a hard reference to the map creator in the model. Instead of listen to the 'onTableAfterStore' event in the plugins/extension/namespacemap/namespacemap.php plugin and recreate the map.
@bembelimen The modified file is extracted before the request is executed, so the new code will be executed, thus we do not need an update for Updater
@laoneo I don't know how onTableAfterStore helps here. If we want to go with plugin approach, I think we can trigger a new event onJoomlaAfterUpdate (we triggered onJoomlaBeforeUpdate earlier) and add new method to plugins/extension/namespacemap/namespacemap.php to re-create the map.
@joomdonation that sounds even better. As I made a bad experience adding new events to Joomla, I'm a bit hesitant to add a new ones, that's why I didn't suggest that.
@bembelimen The modified file is extracted before the request is executed, so the new code will be executed, thus we do not need an update for Updater
Yes, but what happens, if there is a plugin, which uses the new namespaces on a very early trigger (like onAfterInitialize), is this covered?
Yes, but what happens, if there is a plugin, which uses the new namespaces on a very early trigger (like onAfterInitialize), is this covered?
As I understand, that plugin would only run on the next request. In the current request, the new plugin (if added in the update) is not available in database yet, so it is not being executed.
I have tested this item
For the test scenario you should not patch the base 4.0 version but only the version you're updating to. (it's then like 4.0.4 => 4.1).
But anyways, changes are working for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36094.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36094.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36094.
I think not having this in a plugin is probably a good idea here - we don't want any weird issues if we ever namespace the plugin in the future.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-25 21:17:53 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Release Blocker
|
||
Thanks!
hi im having this issue atm and idk what to do, I tried to download the link above but it says not found
please if anyone could help me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36094.
Thanx @Crisje for your tip that worked for me. But why is this still in 4.1.2 code? I did an update from 4.0.3 to 4.1.2 and ran into this error. Kind regards, HaSTe.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36094.
Added the release blocker label as inherited from the issue.