[#36091] - Validated type=number in Modules
- Fixed in Code Base
- 23 Nov 2021
- Medium
- Build: 4.0-dev
- # 36091
- Diff
- Shubhamverma2796:4.0-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Validated type=number so that the user can not set negative values to follow proper form validation.
Testing Instructions
- Select Module-->Articles-Latest. Try to save the module with Articles to display = any -ve value.
- Select Module-->Articles - Newsflash. Try to save the module with Number of Articles = any -ve value.
- Select Module-->Articles - Related. Try to save the module with Maximum Articles = any -ve value.
- Select Module-->Modules: Banners. Try to save the module with Count = any -ve value.
- Select Module-->Feed Display. Try to save the module with Items to Display = any -ve value.
- Select Module-->Latest Users. Try to save the module with Number of Users = any -ve value.
Actual result BEFORE applying this Pull Request
All the fields with the -ve values will be saved successfully before this pr.
Expected result AFTER applying this Pull Request
Invalid field message is displayed.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
I have tested this item
? unsuccessfully on e77961dafter applying the patch, it's not showing "Invalid field message is displayed".This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
so form is getting submitted with -ve values?
yes
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
Before applying patch:
Result : Module saved successfully with a negative value.
After applying patch:
PatchWorked.mp4
Result: Module not saved and "Invalid field" is displayed.
@Ravi-chandra69 but it shouldn't be happen, according to the issue , after submitting with the negative value it should display invalid field
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
@Ravi-chandra69 but it shouldn't be happen, according to the issue , after submitting with the negative value it should display invalid field
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
I think you misunderstood the expected results. Before the patch, the module gets saved with the negative values also after clicking on the save button. But, after applying the patch, if the user tries to save the module with negative values, then the "Invalid field" message is displayed which is the expected behaviour.
You can see in the video uploaded by me, when I try to save with negative value then "invalid field" is displayed.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
Oh ok Fine, Actually I was submitting direct from (http://localhost/joomla-4.0.5/administrator/index.php?option=com_cpanel&view=cpanel&dashboard=system) and through this it direct goes to main page without showing any error, so that's whit seems to me wrong, Now all fine, thanks @Ravi-chandra69
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-23 19:01:52 |
| Closed_By | ⇒ | Quy |
Thank you!
@pritam825 thanks for pointing out that the administration modules are still not getting validated. I will open a pr for the administrator module too.
I have tested this item? unsuccessfully on e77961d
after applying the patch, it's not showing "Invalid field message is displayed".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36091.