[#36078] - [4.0] Pre-update check icon spacing
- Fixed in Code Base
- 20 Nov 2021
- Medium
- Build: 4.0-dev
- # 36078
- Diff
- brianteeman:pre0update
User tests: Successful: Unsuccessful:
This PR removes the class ms-2 from the icon (see screenshot). You will not see any change at all in LTR but with RTL you will see the corrections below.
To test you may need to trick the site to see the pre-update check by setting a custom update url such as https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/36040/downloads/48447/pr_list.xml
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Hmm, with the PR we have no spacing between the longest text and the icon for that text.
That's unrelated to this PR and all to do with the really bad RTL overrides
Hmm, with the PR we have no spacing between the longest text and the icon for that text.
That's unrelated to this PR and all to do with the really bad RTL overrides
That's what I assumed, so I tested your PR with success. Just wanted to have mentioned it so people don't think I am blind.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36078.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36078.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-20 15:11:52 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks
thank you
I have tested this item✅ successfully on 57c73cb
Hmm, with the PR we have no spacing between the longest text and the icon for that text. That's not nice but possibly can be fixed with CSS, and the improvement with the alignment for RTL weights more in my opinion, so for me a successful test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36078.