User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) fixes invalid HTML markup caused by wrong closing tags in PHP files.
Code review:
find ./ -type f -name "*\.php" -exec grep -EHn "</[A-Za-z0-9]+\s*$" {} \;
In addition, check if there are any unwanted visual changes on the views which are fixed by this PR after having applied the patch, which are
Test 2 finds the 2 places which are fixed by this PR:
richard@vmubu01:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.php" -exec grep -EHn "</[A-Za-z0-9]+\s*$" {} \;
./administrator/components/com_associations/tmpl/associations/modal.php:171:</div
./components/com_contact/tmpl/category/default_items.php:126: </div
richard@vmubu01:~/lamp/public_html/joomla-cms-4.0-dev$
Test 2 finds nothing.
There are no visual changes in the views fixed by this PR.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_associations Front End com_contact |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-20 15:11:24 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
?
|
Thanks
I have tested this item✅ successfully on 4067816
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36079.