? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
20 Nov 2021

Pull Request for Issue # .

Summary of Changes

This pull request (PR) fixes invalid HTML markup caused by wrong closing tags in PHP files.

Testing Instructions

Code review:

  1. Check that the changes made by this PR are right.
  2. Check that it covers all places in PHP files, e.g. by using following command on Linux in a command shell in your Joomla root folder:
find ./ -type f -name "*\.php" -exec grep -EHn "</[A-Za-z0-9]+\s*$" {} \;

In addition, check if there are any unwanted visual changes on the views which are fixed by this PR after having applied the patch, which are

  • The multilanguage associations modal in backend.
  • A list all contacts in a category view (or something like that) in frontend.

Actual result BEFORE applying this Pull Request

Test 2 finds the 2 places which are fixed by this PR:

richard@vmubu01:~/lamp/public_html/joomla-cms-4.0-dev$ find ./ -type f -name "*\.php" -exec grep -EHn "</[A-Za-z0-9]+\s*$" {} \;
./administrator/components/com_associations/tmpl/associations/modal.php:171:</div
./components/com_contact/tmpl/category/default_items.php:126:								</div
richard@vmubu01:~/lamp/public_html/joomla-cms-4.0-dev$

Expected result AFTER applying this Pull Request

Test 2 finds nothing.

There are no visual changes in the views fixed by this PR.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 20 Nov 2021
avatar richard67 richard67 - change - 20 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2021
Category Administration com_associations Front End com_contact
avatar richard67 richard67 - change - 20 Nov 2021
The description was changed
avatar richard67 richard67 - edited - 20 Nov 2021
avatar richard67 richard67 - change - 20 Nov 2021
The description was changed
avatar richard67 richard67 - edited - 20 Nov 2021
avatar brianteeman brianteeman - test_item - 20 Nov 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Nov 2021

I have tested this item successfully on 4067816


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36079.

avatar chmst chmst - test_item - 20 Nov 2021 - Tested successfully
avatar chmst
chmst - comment - 20 Nov 2021

I have tested this item successfully on 4067816


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36079.

avatar chmst chmst - change - 20 Nov 2021
Status Pending Ready to Commit
avatar chmst
chmst - comment - 20 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36079.

avatar Quy Quy - close - 20 Nov 2021
avatar Quy Quy - merge - 20 Nov 2021
avatar Quy Quy - change - 20 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-20 15:11:24
Closed_By Quy
Labels Added: ? ?
avatar Quy
Quy - comment - 20 Nov 2021

Thanks

Add a Comment

Login with GitHub to post a comment