Feeling Lucky
?
?
[#36077] - [4.0] pre-update check unused class
- Fixed in Code Base
- 20 Nov 2021
- Medium
- Build: 4.0-dev
- # 36077
- Diff
- brianteeman:text-left
User tests: Successful: Unsuccessful:
Simple PR to remove a class that doesn't exist in the css stylesheet
No visible changes obviously
Code review only
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Shubhamverma2796
- comment
- 20 Nov 2021
I have tested this item
The class "text-left" is not present in any of the CSS or SCSS file
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36077.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 20 Nov 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36077.
khu5h1
- comment
- 20 Nov 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36077.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-20 15:11:01 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 20 Nov 2021
Thanks
brianteeman
- comment
- 20 Nov 2021
thank you
I have tested this item✅ successfully on 1eabb2b
I've verified that "text-left" doesn't appear in any scss or any relevant css file and that removing it doesn's cause any visual change.
Hint for other testers: You can get the pre-update check shown in a Joomla 4.0 by changing the update channel to use the custom URL https://update.joomla.org/core/nightlies/next_minor_list.xml . You will be offered to update to 4.1 and the checks are shown.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36077.