@brianteeman do you know if the aria-setsize, aria-posinset and aria-level are fully supported/correctly calculated on all evergreen browsers? Ref: https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html

Sorry I don't know. I will do some research tomorrow. Caveat a lot of the examples on that site are not very good

Do you have a solid example for tree view? I use some of the links from w3c/aria#1311

Not at my pc but the link I shared the other day in the media manager pr looked good

Not at my pc but the link I shared the other day in the media manager pr looked good

It's sharing the same code as https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html
Anyways I will code something and we can improve/iterate...

@dgrammatiko I checked out the PR but I got a some warnings in the template view.

@dgrammatiko I checked out the PR but I got a some warnings in the template view.

@RickR2H good catch, should be fine now

The default thumb isn't working ;)

Some warnings still appear:

Warning: Undefined variable $key in C:\wamp64\www\testing\administrator\components\com_templates\tmpl\template\default.php on line 91 Call Stack #TimeMemoryFunctionLocation 10.0002366680{main}( )...\index.php:0 20.0003367448require_once( 'C:\wamp64\www\testing\administrator\includes\app.php )...\index.php:32 30.01661276768Joomla\CMS\Application\CMSApplication->execute( )...\app.php:63 40.01711359128Joomla\CMS\Application\AdministratorApplication->doExecute( )...\CMSApplication.php:278 50.07222317544Joomla\CMS\Application\AdministratorApplication->dispatch( $component = ??? )...\AdministratorApplication.php:186 60.07732448944Joomla\CMS\Component\ComponentHelper::renderComponent( $option = 'com_templates', $params = ??? )...\AdministratorApplication.php:143 70.08122511504Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch( )...\ComponentHelper.php:389 80.08182522928Joomla\CMS\MVC\Controller\BaseController->execute( $task = 'display' )...\ComponentDispatcher.php:146 90.08182522928Joomla\Component\Templates\Administrator\Controller\DisplayController->display( $cachable = ???, $urlparams = ??? )...\BaseController.php:730 100.08192522928Joomla\CMS\MVC\Controller\BaseController->display( $cachable = ???, $urlparams = ??? )...\DisplayController.php:67 110.08372620904Joomla\Component\Templates\Administrator\View\Template\HtmlView->display( $tpl = ??? )...\BaseController.php:692 120.12822878352Joomla\CMS\MVC\View\HtmlView->display( $tpl = NULL )...\HtmlView.php:230 130.12842880096Joomla\CMS\MVC\View\HtmlView->loadTemplate( $tpl = NULL )...\HtmlView.php:221 140.12962901864include( 'C:\wamp64\www\testing\administrator\components\com_templates\tmpl\template\default.php )...\HtmlView.php:432 " href="">

Warning: Undefined property: Joomla\CMS\Object\CMSObject::$inheritable in C:\wamp64\www\testing\administrator\components\com_templates\tmpl\template\default.php on line 379

full path is added to the folder structure in the explorer on the left.

full path is added to the folder structure in the explorer on the left.

That's a winDOS thing. I have to check where that FS fails

full path is added to the folder structure in the explorer on the left.

That's a winDOS thing. I have to check where that FS fails

That explains why the links are all failing. Clicking the files in the tree results in a "File not found" error and a lot of warnings. Let me know if you need more info. We can use Glip if you want, so we don't spam the Git stream to much.

Keep me posted!

@RickR2H Did 411a9f5 fixed the full path? Also you should have proper thumbs now

Folders and files work. One thing I noticed is that the folders now haven an additional "/"

Installing the Cassy template worked. Creating the child worked too. On opening the child I get notices:

Is it correct that a child template folder only has a templateDetails.xml to start with?

On opening the child I get notices:

Should be ok now. You will need to manually uninstall the child and recreate it

Is it correct that a child template folder only has a templateDetails.xml to start with?

Yes, that's the beauty of it, you can add overrides without touching the parent template which could now safely be updated and your overrides will be retained...

Thank you @dgrammatiko for this nice feature!!!

I started to test and my main concern is, that the folder structure change is quite confusing and not a nice change for a user.

I understood that this way it's more secure and I am gonna live with tha ;-).

But the folder structure display is very confusing. It does not display the "reality"
So to make it clear where the files are flying around, it would be good to clarify to the user in the folder structure images what happens.

Maybe something like that:

At the overrides tab, shouldn't be there also the files from the parent template to click on?

I made an override of index.php, and afterwards I made a change in the main template index.php but the changes have not been recognized.

I created a .js file in the media js folder, clicked on delete, i got a success message but the file is still there:

Edit: instead of the template.js file in the media folder which I had selected. the template.js file in the root:/templates/ structure was deleted (which was not selected)

Template Overview:
The Override Files information is wrong here too (because the index.php is behind the parent version) and it would be great if the childtemplates would be little bit intended so that its better recognizeable that they are childs.
At the create child process it would be great if it takes the username in the author column and the current date.
Additionally, if possible, the version could be increased by every change - but I see that there are issues finding the right versioning pattern.

@coolcat-creations Agree with indenting child templates. But I think layout improvements can be added also after merge.

About the update notification: As much as I know, this function observes only the overrides in html.

But the folder structure display is very confusing. It does not display the "reality"

The reason I didn't wrote some extensive testing instructions on these PRs was to get such valuable responses. If I had verbally explained the UI you might have thought "ah, that makes sense" but that would be cheating. Thanks! Will add the paths (easy one). Done ✅

Is this any better:

I made an override of index.php, and afterwards I made a change in the main template index.php but the changes have not been recognized.

That's normal, the update files work only on layout overrides. The logic hasn't changed but the question is should it also include the parent template files? (btw I don't know if that is even possible, templates could have any filename as their entry point: index, component, error, 404, dimitris...) @bembelimen any input here?

I created a .js file in the media js folder, clicked on delete, i got a success message but the file is still there:

Ok, that's a bug, fixed ✅

At the overrides tab, shouldn't be there also the files from the parent template to click on?

Good question. Fwiw I'm still in favour of https://user-images.githubusercontent.com/3889375/132101328-be1643c8-e9af-4b75-8645-a9162d554214.mp4 and the #32896 in general but that won't happen in 4.x

At the create child process it would be great if it takes the username in the author column and the current date.

Easily doable: done ✅

if the childtemplates would be little bit intended so that its better recognizeable that they are childs.

I'm not sure how this would look like. The infos are in a table cell

Please keep reporting anything that you feel it's not good, so I could try to fix it. ?

I'm not sure how this would look like. The infos are in a table cell

Maybe a fa-angle-right before can do it (in ltr languages).

Maybe a fa-angle-right before can do it (in ltr languages).

What about rtl? Will fa-angle-left be ok?

@dgrammatiko I think so. I will need a test with ltr language. No clue atm how the table looks like in rtl

Wow, thank you @dgrammatiko for the fast response and fixes!

For:

I made an override of index.php, and afterwards I made a change in the main template index.php but the changes have not been recognized.

That's normal, the update files work only on layout overrides. The logic hasn't changed but the question is should it also include the parent template files? (btw I don't know if that is even possible, templates could have any filename as their entry point: index, component, error, 404, dimitris...) @bembelimen any input here?

For me a childtemplate is basically an override if not it should be clarified to the user. Comparing between the parent template and the childtemplate is very very important I think...

Please keep reporting anything that you feel it's not good, so I could try to fix it. ?

Thank you! I will test tomorrow again :-)

@bembelimen any feedback about the override-check issue? I think it's one very important thing to have here - its basically the first questions someone has when doing changes on templates "How to recognize changes that have been done to the main template by updates"

@bembelimen any feedback about the override-check issue? I think it's one very important thing to have here - its basically the first questions someone has when doing changes on templates "How to recognize changes that have been done to the main template by updates"

Yes, but not in this PR please. Otherwise we kill ourself (mostly @dgrammatiko ) and never get it done in a first version.
It would be a very nice feature, but is not a "must have or we'll all die" thing.

That's normal, the update files work only on layout overrides. The logic hasn't changed but the question is should it also include the parent template files? (btw I don't know if that is even possible, templates could have any filename as their entry point: index, component, error, 404, dimitris...) @bembelimen any input here?

Yes, it should be possible, but also not in this PR. I think that needs some more thoughts, like see the parent files in a different color and when you edit them in the child, the changes will be copied to the child.

I also see a compare function in the future....but not now.

@dgrammatiko a agle-left is ok

These layout changes can be done later. It is more important to get the PR merged and the care for details

@chmst I added a badge so the view is more like

Should I also add the angle icon to signify the child template?

Should I also add the angle icon to signify the child template?

Not for me

the badge is nice! Like it :-)

Please match the button icon to the quick icon.

@Quy the icon is unrelated to this pr. It was wrong before see #36136

Updated a fresh 4.1 with the update file and installed cassy.
When editing a file, the file name should be visible. Here I have the number "226" for all files:

Here I have the number "226" for all files

Fixed with b962afb

@chmst could you try bfe1eb6 It should use / for all the directory seperators. Unfortunatelly this affects windows users and I can't test it here

Ok for the slashes.

It remains the "226" instead filename.

Ok for the slashes.

There is an extra slash in the editing file part

I need new glasses

@chmst did 4e76c7b fixed the double //?

Actual result.

@chmst is there anything left here that's not fixed?

I found double slashes also here:

found double slashes also here:

Should be fixed with 2359e7f

Same in rename file modal ;)

@dgrammatiko Do the testing instructions already include the changes from merging in #36011 ? Or is there something missing?

Or is there something missing?

No, the instructions need update. I'm on it

Slashes in Foldernames seem to be ok now.

@dgrammatiko I have created a child template of the Cassy which I had installed before on a 4.1-dev with this PR applied. After that, each time when I edit and save parameters of the template style of that child, I get 3 PHP notices in my PHP error log:

PHP Notice:  Trying to get property 'parent' of non-object in /joomla-cms-4.1-dev/administrator/components/com_templates/src/Model/StyleModel.php on line 422, referer: https://www.joomla-41-dev.vmubu01.vmnet2.local/administrator/index.php?option=com_templates&view=style&layout=edit&id=14
PHP Notice:  Trying to get property 'parent' of non-object in /joomla-cms-4.1-dev/administrator/components/com_templates/src/Model/StyleModel.php on line 423, referer: https://www.joomla-41-dev.vmubu01.vmnet2.local/administrator/index.php?option=com_templates&view=style&layout=edit&id=14
PHP Notice:  Trying to get property 'parent' of non-object in /joomla-cms-4.1-dev/administrator/components/com_templates/src/Model/StyleModel.php on line 423, referer: https://www.joomla-41-dev.vmubu01.vmnet2.local/administrator/index.php?option=com_templates&view=style&layout=edit&id=14

Could you check that?

Besides this, things seem to work ok so far.

P.S.: The PHP notices reported above happen only when saving the parameters of a child template's template style (Cassy in this case). They don't happen when editing the parameters of a normal (or copy of a normal) template's template style.

@richard67 what's the data in the ``#__template_styles`? Are the parent columns filled for the child?

@dgrammatiko Looks ok to me. But can it be that more than one template style for a child template is not supported?

When I make the template style of the child template be the default, I get no CSS from the parent loaded.

Backend template styles:

The names for your child templates are off, should be cassy_child* instead of cassy_cassy* Althought this shouldn't be the problem.

But can it be that more than one template style for a child template is not supported?

No, styles are just the JSON blob from the db so there shouldn't be a limit on the copies...

When I make the template style of the child template be the default, I get no CSS from the parent loaded.

Does the folders media/templates/site/cassy/... exist? This is weird...

Does the folders media/templates/site/cassy/... exist? This is weird...

@dgrammatiko Yes, it exists. I've created another child with a more suitable name but that did not help.

Another thing I have noticed is that I can created new child templates, but I cannot delete them. Is that by design or will the delete come later with another PR?

@dgrammatiko It seems it loads the template css files from the media/templates/site/cassy/css folder, but stuff from sub-folders "global", "system" and "vendor" is not included.

@dgrammatiko It seems it loads the template css files from the media/templates/site/cassy/css folder, but stuff from sub-folders "global", "system" and "vendor" is not included.

P.S. Could that be an issue of the Cassy template?

Another thing I have noticed is that I can created new child templates, but I cannot delete them. Is that by design or will the delete come later with another PR?

Actually, you can already, got to System->Extentions, select templates in the filters and then delete any child template (probably not the most intuitive workflow)...

By the way, can you remove all the preexisted templates and try again your tests, something seems awfully wrong but I can't pinpoint what it is...

@dgrammatiko I've tried again from scratch with a new installation of this branch. This time only one language, no template style copies, nothing special. I only installed the Cassy template and made it's template style the default. That worked, i.e. frontend looked ok. Then I have created a child template named "Child_1", so the generated name at the end was "Cassy_cild_1"- That worked. But then I make the template style of this child be the default, the frontpage looks like in my screenshot, i.e. some but not all CSS seems not to be loaded.

@dgrammatiko Is it possible to test with both PRs #35874 and this here together? Or do they conflict somehow?

ut then I make the template style of this child be the default, the frontpage looks like in my screenshot, i.e. some but not all CSS seems not to be loaded.

Yeah there was something off in the cassy template, try this Cassy_new.zip

Is it possible to test with both PRs #35874 and this here together? Or do they conflict somehow?

I think there is nothing that conflicts, so they could be tested together. Remember to apply the db changes...

@dgrammatiko I have just tested now with the both PR's merged together in a branch. I don't have the problem when creating a child template of the (now inheritable) Cassiopeia and then make the template style of that child be the default.

So it either is an issue with Cassy or it needs both PR's together.

I have tested this item ✅ successfully on 7a95857

Template manager works well with inheritable and not inheritable templates and with child templates of inheritable templates.

The right editor.css is included when editing with TinyMCE in backend, regardless if the default template style is one of an inheritable or a not inheritable template or the child template of an inheritable template.

I've tested this PR alone with the core templates being not inheritable and the inheritable Cassy template installed (fixed version), and I also have texted it in combination with PR #35874 so the core templates were inheritable.

Both worked.

If there are minor glitches which I've missed in my tests, I think they can be fixed later.

I have tested this item ✅ successfully on 7a95857

Did all what I can imagine for child template and using templates and template styles - all went well.

RTC

I've added back the previous test results in the issue tracker since the last commit was just the removal of an obsolete "use" statement.

Thank you!