Feeling Lucky
?
[#36000] - [4.1] TinyMCE changes for child templates 3/3
- Closed
- 11 Nov 2021
- Medium
- Build: 4.1-dev
- # 36000
- Diff
- dgrammatiko:4.1-dev-tinyMCE-Editor-CSS
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Modified
HTMLHelper::includeRelativeFilesto accept the template as an object - Modified
HTMLHelper::image,HTMLHelper::stylesheetandHTMLHelper::scriptto accept the template as an object in the options - Modified the
getTemplate()in the apps to also have the client_id in the returned object - Finally use
HTMLHelper::stylesheetin the tinyMCE for theeditor.css(solves also the .min bug)
Testing Instructions
Apply the patch in the current 4.1
Verify that the editor.css is loading as expected
Apply #35874 and then this PR
Verify that the editor.css is loading as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No debug:
With debug enabled:
Documentation Changes Required
The changes ARE B/C, nothing is breaking here. The concept of passing the template as an object to the 3 helper functions means that we don't have to replicate the existing relative loading procedure in the tinyMCE (maybe it would be helpful for other scenarios)
@bembelimen @laoneo @wilsonge could you guys review this one?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-11 16:59:52 |
| Closed_By | ⇒ | dgrammatiko |
replaced by #36011