? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
26 Oct 2021

Summary of Changes

Blog Sample Data can be installed only once. When the user repeats the installation, the installation fails with a message.
For new users this message is somehow cryptic. We can add a clearer information.

Testing Instructions

Install the Blog Sample Data once, then install again and see the error message.

Actual result BEFORE applying this Pull Request

Step 1 Failed with message: Another Tag has the same alias (remember it may be a trashed item).

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar chmst chmst - open - 26 Oct 2021
avatar chmst chmst - change - 26 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2021
Category Administration Language & Strings
avatar chmst chmst - change - 26 Oct 2021
Labels Added: Language Change ?
avatar chmst
chmst - comment - 26 Oct 2021

Thanks!

avatar ChristineWk
ChristineWk - comment - 26 Oct 2021

Got this message. See second sentence:

screen shot 2021-10-26 at 20 41 33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar ChristineWk
ChristineWk - comment - 26 Oct 2021

I have tested this item successfully on f1cf9ba

OK, I saw the change now on Github View.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar ChristineWk ChristineWk - test_item - 26 Oct 2021 - Tested successfully
avatar rjharishabh rjharishabh - test_item - 27 Oct 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 27 Oct 2021

I have tested this item successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar rjharishabh rjharishabh - change - 27 Oct 2021
Status Pending Ready to Commit
avatar rjharishabh
rjharishabh - comment - 27 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar khu5h1
khu5h1 - comment - 28 Oct 2021

I have tested this item successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar khu5h1 khu5h1 - test_item - 28 Oct 2021 - Tested successfully
avatar bembelimen
bembelimen - comment - 2 Nov 2021

I think the communication is good thing in general, but I think this is only a band aid for the deeper problem (and does not fix it at all), which means, if the plugin is changed and e.g. there is a new order of steps or forever reasons the user cleans up the content from step 1, the installation will fail again with another error message.
So I think this should be considerated, too.

avatar brianteeman
brianteeman - comment - 2 Nov 2021

I agree. If it can only be installed once then it should be removed automatically once it has run

avatar chmst
chmst - comment - 19 Nov 2021

I know that #22634, #20479
It was an attempt to make it a little bit clearer as long as we have not good solution

avatar pritam825 pritam825 - test_item - 23 Nov 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 23 Nov 2021

I have tested this item successfully on f1cf9ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35910.

avatar wilsonge
wilsonge - comment - 28 Nov 2021

The key thing is you can do only do once on a per-language basis (see #23633 (comment)). I'm merging this for now and if we can find a better solution we can always revert this.

avatar wilsonge wilsonge - change - 28 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-28 17:40:50
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Nov 2021
avatar wilsonge wilsonge - merge - 28 Nov 2021
avatar wilsonge
wilsonge - comment - 28 Nov 2021

Thanks!

Add a Comment

Login with GitHub to post a comment