User tests: Successful: Unsuccessful:
Pull Request for Issue #35229 .
I have enabled focus on media files by changing their tabindex
from -1 to 0.
Check out issue #35229 for testing and reproducing the PR.
Unable to focus on media files while using the tab button.
Enabled to focus in media files using the tab button.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media NPM Change |
@khu5h1 Shouldn't it be changed here, too? https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_media/resources/scripts/components/tree/drive.vue#L45
Does it even need a tabindex - ever?
Does it even need a tabindex - ever?
If it non interactive element (like a, button, input), and need "tab navigation" then yes.
If it non interactive element (like a, button, input), and need "tab navigation" then yes
buttons and inputs are interactive
buttons and inputs are interactive
yes, I meant: .. if not like a button or input ;)
there can stay as is, if it works
Title |
|
Labels |
Added:
NPM Resource Changed
?
|
Silly question: Why is this PR targeted for 4.1? Is it a new feature? If it's a bug fix it should go into 4.0.
Thank you @Fedik for your suggestion and I have committed the desired change.
And as per @richard67 's comment, I am not sure that whether we shall commit the change to drive.vue
or not. As IMO that won't have any impact on the issue.
Regards
Silly question: Why is this PR targeted for 4.1? Is it a new feature? If it's a bug fix it should go into 4.0.
I am not sure about that, If that's the case, I will have to rebase my PR to 4.0-dev
. I may do that if that sounds good.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
@richard67 I was not aware of the same. Thanks for your comment. I will keep this in mind for future PRs.
Also, I would request @encrypt3r12 and @manav014 to please test this PR again.
I have tested this item
I have tested this item
Thanks, everyone :)
I have tested this item
Sorry this is completely wrong.
Firstly the expected behaviour for a tree view is to navigate between the tree items with the arrow keys and not the tab key
Secondly while this pr does appear to navigate between tree items with a tab it does not allow you to select a tree item using the keyboard
Thirdly If you have a nested tree then the tab key will select the entire nested tree as a single item
Status | Ready to Commit | ⇒ | Pending |
Back to pending after unsuccessful test.
@richard67 I was not aware of the same. Thanks for your comment. I will keep this in mind for future PRs.
@khu5h1 Thank you. It was not a big problem, I only wanted to let you know that it was not necessary. And thanks for your contributions and testing other PR's. It's really appreciated, regardless of the unsuccessful test above (that can happen to anybody of us).
Firstly the expected behaviour for a tree view is to navigate between the tree items with the arrow keys and not the tab key
Secondly while this pr does appear to navigate between tree items with a tab it does not allow you to select a tree item using the keyboard
Thirdly If you have a nested tree then the tab key will select the entire nested tree as a single item
@brianteeman Actually, I thought that the expected behavior is to navigate with tab key. I will modify this PR to make it compatible to move across items with arrow key. Also, I just realized that it is not allowing me to select nested tree items so that's also is to be done.
May anyone please suggest me some code pointers or references to solve the problem.
@richard67 Thanks for the appreciation. I totally understand that it is common for tests to be failed and I will modify my PR accordingly to pass the tests.
Maybe this information will help you https://www.levelaccess.com/creating-an-accessible-aria-tree-control/
Status | Pending | ⇒ | Needs Review |
Needs some more work.
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-27 14:40:43 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
Removed: ? |
I have tested this item✅ successfully on 4bd85f5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35911.