? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar kochinc
kochinc
26 Oct 2021

In administrator/components/com_installer/src/Model/WarningsModel.php the minimum required value for both post_max_size and upload_max_filesize is set to 16MB ($minMemory). The warning descriptions should reflect that.

Pull Request for Issue # (N/A).

Summary of Changes

Correct minimum value in warning descriptions.

Testing Instructions

Set post_max_size and upload_max_filesize to 10MB in /etc/php.ini.

Actual result BEFORE applying this Pull Request

Got these 2 warnings in System -> Information -> Warnings, even though those values are larger than the minimum required shown in the warnings:

"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 8MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."

"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 8MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."

Expected result AFTER applying this Pull Request

The correct warnings should be:

"Small PHP maximum POST size.
This is the maximum amount of data that can be sent via POST to the server. This includes form submissions for articles, media (images, videos) and extensions. This value is less than 16MB which may impact on uploading large extensions. This is set in the php.ini under post_max_size."

"Maximum PHP file upload size is too small.
The maximum file size for uploads is set to less than 16MB which may impact on uploading large extensions. This is set in php.ini in both the upload_max_filesize and post_max_size settings of your PHP settings (located in php.ini and/or .htaccess file). The value of post_max_size must be greater than the value of upload_max_filesize."

Documentation Changes Required

None

avatar kochinc kochinc - open - 26 Oct 2021
avatar kochinc kochinc - change - 26 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2021
Category Administration Language & Strings
avatar richard67 richard67 - test_item - 28 Oct 2021 - Tested successfully
avatar richard67
richard67 - comment - 28 Oct 2021

I have tested this item successfully on 053a0ae

The change of the messages is correct.

The corresponding change of the minimum sizes from 8 to 16 MB has been made with PR #34754 here https://github.com/joomla/joomla-cms/pull/34754/files#diff-0998cd4637eab77ec0459b0d09df3bf6c093d012ed0ec6e7f5ab3f19bd9c3a6c

Tested by code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

avatar richard67
richard67 - comment - 28 Oct 2021

P.S.: The string "COM_INSTALLER_MSG_WARNINGS_MEDMEMORYDESC" seems to be already ok, i.e. it seems to reflect already the change from PR #34754 , so the fix made here seems to be complete.

avatar Quy Quy - test_item - 28 Oct 2021 - Tested successfully
avatar Quy
Quy - comment - 28 Oct 2021

I have tested this item successfully on 053a0ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

avatar Quy Quy - change - 28 Oct 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35909.

avatar Quy Quy - change - 28 Oct 2021
Labels Added: ?
avatar bembelimen bembelimen - change - 2 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-02 16:14:18
Closed_By bembelimen
Labels Added: ? Language Change
avatar bembelimen bembelimen - close - 2 Nov 2021
avatar bembelimen bembelimen - merge - 2 Nov 2021
avatar bembelimen
bembelimen - comment - 2 Nov 2021

Thx

Add a Comment

Login with GitHub to post a comment