? Pending

User tests: Successful: Unsuccessful:

avatar basd82
basd82
24 Oct 2021

Made pull request like sugested by Richard Fath

I made this change to 4.0-dev branch becouse they are fixes that are only valid voor 4.x

avatar basd82 basd82 - open - 24 Oct 2021
avatar basd82 basd82 - change - 24 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2021
Category Front End com_content com_finder com_users
avatar basd82 basd82 - change - 24 Oct 2021
Title
Getdbo patch (joomla#35884)
Getdbo patch fixes #35884
avatar basd82 basd82 - edited - 24 Oct 2021
avatar ceford
ceford - comment - 27 Oct 2021

This PR needs a description and testing instructions as in all other properly documented PRs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35888.

avatar basd82
basd82 - comment - 30 Oct 2021

Pull Request for Issue # 35884

Summary of Changes

Replaced Getdbo() becouse it is deprecated

Testing Instructions

Test if the following component's in the frontend are still working like before:
com_users
com_content
com_finder

Actual result BEFORE applying this Pull Request

Messages about depricated calls to getDbo() in adminstrator/log/depricated.php

Expected result AFTER applying this Pull Request

No more log messages for these components

Documentation Changes Required

None that i can think off

avatar basd82
basd82 - comment - 30 Oct 2021

Pull Request for Issue # 35884

Summary of Changes

Replaced Getdbo() becouse it is deprecated

Testing Instructions

Test if the following component's in the frontend are still working like before:
com_users
com_content
com_finder

Actual result BEFORE applying this Pull Request

Messages about depricated calls to getDbo() in adminstrator/log/depricated.php

Expected result AFTER applying this Pull Request

No more log messages for these components

Documentation Changes Required

None that i can think off

avatar basd82
basd82 - comment - 30 Oct 2021

This PR needs a description and testing instructions as in all other properly documented PRs.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35888.

Added the request pr

avatar alikon
alikon - comment - 31 Dec 2021

thank you @basd82 superseded by #36502

avatar alikon alikon - change - 31 Dec 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-12-31 17:00:27
Closed_By alikon
Labels Added: ?
avatar alikon alikon - close - 31 Dec 2021
avatar alikon alikon - change - 31 Dec 2021
Status Closed New
Closed_Date 2021-12-31 17:00:27
Closed_By alikon
avatar alikon alikon - change - 31 Dec 2021
Status New Pending
avatar alikon alikon - reopen - 31 Dec 2021
avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

There is no point reopening this after you threw your toys out your cot after being asked to make 12 lines of copy and paste changes - it’s no better than the PR you proposed.

I’ll make a PR later tonight that does it correctly, completely, in all places

avatar alikon alikon - change - 31 Dec 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-12-31 17:14:27
Closed_By alikon
avatar alikon
alikon - comment - 31 Dec 2021

looking forward for your pr

avatar alikon alikon - close - 31 Dec 2021
avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

PR Provided as #36511

Add a Comment

Login with GitHub to post a comment