Release Blocker ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Oct 2021

Changelogs

TinyMCE 5.10

https://www.tiny.cloud/docs/changelog/#5100-2021-10-11

Resolve three outdated settings that are deprecated and will be removed in 6.0
Show deprecated notices when debug is enabled

Codemirror 5.63.3

https://github.com/codemirror/CodeMirror/releases/tag/5.63.2

avatar brianteeman brianteeman - open - 24 Oct 2021
avatar brianteeman brianteeman - change - 24 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2021
Category NPM Change Front End Plugins
avatar dgrammatiko
dgrammatiko - comment - 24 Oct 2021

@brianteeman could you add 'deprecation_warnings' => false in the default options array as per their docs: https://www.tiny.cloud/docs/release-notes/6.0-upcoming-changes/

I haven't tested but I suspect that there will be a lot of deprecations logged in the browser's console...

EDIT: This 'deprecation_warnings' => JDEBUG? true : false might be a better fit now that I'm thinking about it

avatar brianteeman
brianteeman - comment - 24 Oct 2021

not a fan of adding that

avatar dgrammatiko
dgrammatiko - comment - 24 Oct 2021

not a fan of adding that

That's fine, by the way, you need to also update the package.json for the TinyMCE as 5.9.2 and 5.10.0 are different patch versions snd NPM will not automatically fetch the latter

avatar brianteeman
brianteeman - comment - 24 Oct 2021

yes it will - at least it did for me

avatar brianteeman
brianteeman - comment - 25 Oct 2021

Sorry I misunderstood you. It was late, I thought you were asking me to ADD the deprecated notices, not to remove them. Updating this PR shortly

avatar brianteeman brianteeman - change - 25 Oct 2021
Labels Added: ? NPM Resource Changed
avatar brianteeman brianteeman - change - 25 Oct 2021
The description was changed
avatar brianteeman brianteeman - edited - 25 Oct 2021
cb781cf 25 Oct 2021 avatar brianteeman debug
avatar brianteeman brianteeman - change - 25 Oct 2021
The description was changed
avatar brianteeman brianteeman - edited - 25 Oct 2021
avatar brianteeman
brianteeman - comment - 25 Oct 2021

There were only three deprecation notices which I have resolved

gecko_spellchecker
force_p_newlines
inline_styles

avatar brianteeman
brianteeman - comment - 8 Nov 2021

took so long it has now been updated to 5.10.1

avatar brianteeman
brianteeman - comment - 18 Nov 2021

Took so long its now been updated to 5.10.2

avatar brianteeman brianteeman - change - 18 Nov 2021
Labels Added: Release Blocker
avatar wilsonge wilsonge - change - 21 Nov 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-21 21:20:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Nov 2021
avatar wilsonge wilsonge - merge - 21 Nov 2021
avatar wilsonge
wilsonge - comment - 21 Nov 2021

Thanks!

avatar brianteeman
brianteeman - comment - 21 Nov 2021

finally

thanks

Add a Comment

Login with GitHub to post a comment