[#35887] - [4.1] Refactor vue browser items
- Fixed in Code Base
- 13 Nov 2021
- Medium
- Build: 4.1-dev
- # 35887
- Diff
- Digital-Peak:j4/refactor/vue/browser
User tests: Successful: Unsuccessful:
Followup pr of #35332.
Summary of Changes
As #35332 gets abandoned, this one here is a conflict fix. All the old commits should be preserved.
More information can be found in the pr #35332 by @JenSeReal.
Testing Instructions
Open media manager and execute the actions and browse around.
Actual result BEFORE applying this Pull Request
All should work.
Expected result AFTER applying this Pull Request
All should work.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
?
|
||
@laoneo System test is failing, I've tried to restart several times now but it always fails at the same place, so maybe it's related to this PR: https://ci.joomla.org/joomla/joomla-cms/48082/1/22
It always fails at the test "Test that it is possible to navigate to a subfolder using double click.".
The screenshot from the test doesn't show anything special: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.1-dev/35887/system-tests/48082
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.
I have tested this item
Tested as a user, without inspecting the code and English language. From a uses point of view the PR works good, no errors or notices found.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.
RTC
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.
Note for maintainers: When merging with a squash commit, don't remove the "co-authored by" tags in the commit description generated by GitHub so that the author of the original PR is not forgotten.
Can someone do some quick a11y validation on this one. I assume as we still have the unordered list it's ok. But some of the html here was refactored from divs to ul's originally for proper screenreader compat
| Labels |
Added:
?
|
||
@brianteeman can you have a look on the concern from @wilsonge?
Please ask the accessibility team
I will ping them on Glip.
@richard67 thanks
@dgrammatiko The thing is that while this PR was in progress, changes on the code which is moved around by this PR have been made, and so there were conflicts which were resolved. I think George just wants to be sure that the other changes have been applied to this PR when the conflicts were solved.
I can confirm there are no html structural changes from an a11y point of view. Whenever there should be a list, there is a list and no divs are involved. Also with this refactoring, checking the code and A11y fixes will be simpler as we will split longer code in vue components reusing the markup.
I do think this is a RTC!!
Is is RTC already.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-13 23:10:57 |
| Closed_By | ⇒ | bembelimen |
Thx
@laoneo can you please run lint/fix?
npm run lint:js -- --fixshould do the trick