User tests: Successful: Unsuccessful:
Cache::setWorkarounds()
incorrectly returns ALL current assets even if headerbefore
option exists and a module/view didn't actually add any own assets.This results in incremental caching of all assets in the cache of each module. Tons of WebAssets events are next executed on module cache load via Cache::getWorkarounds()
and the load time is seriously affected.
Iterating over $wa->getManagerState()['activeAssets']
does not requires checking the ASSET_STATE_ACTIVE
state because this array holds only active assets
The resulting array of getHeadData()['assetManager']['assets']
didn't have the asset name as key which prevents the fast cache workarounds comparison
Enable Joomla conservative caching, browse frontend pages as guest
Explore the contents of module cache files, see that they contain all WebAssetItem
objects existing at the time of caching.
Note the cache file size.
See that cache file size in much smaller now (delete old files first), see that the module cache now only have the assets really added by this module.
No.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Title |
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-14 05:45:21 |
Closed_By | ⇒ | Denitz |
I have tested this item✅ successfully on 2c12962
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35776.