Conflicting Files NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
7 Oct 2021

Summary of Changes

/atum/scss/pages contains page specific styling, which should be moved to separate CSS files, so that their only loaded on said specific page, rather than globally.

This PR moves the com_templates styling to a separate CSS file

Testing Instructions

  1. Run npm i
  2. Go to administrator/index.php?option=com_templates&view=styles
  3. Open the Cassiopeia template
  4. Go to the Menu Assignment tab

Expected result AFTER applying this Pull Request

The styling should be the same as before, but you should be able to confirm it derives from the separate CSS file:

image

image

avatar C-Lodder C-Lodder - open - 7 Oct 2021
avatar C-Lodder C-Lodder - change - 7 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2021
Category Administration com_templates Templates (admin) NPM Change Repository
avatar brianteeman
brianteeman - comment - 7 Oct 2021

will you be moving all the other pages and does it really matter for so few lines?

avatar C-Lodder
C-Lodder - comment - 7 Oct 2021

If this is desired, then I suppose I can do the other pages.

does it really matter for so few lines

It's not so much the line count that matters, but spliting page specific CSS rather than just bundling everything up into a single file. No point in loading unused CSS where possible.

avatar brianteeman
brianteeman - comment - 7 Oct 2021

i dont really see the need myself for such micro-optimisation in the admin but if its done for one "page" it really should be done for all.

avatar dgrammatiko
dgrammatiko - comment - 7 Oct 2021

i dont really see the need myself for such micro-optimisation in the admin

It's a good thing to actually demonstrate best practices. We did this already for vendor (I think I did that) and the reason is cache invalidation, eg if we have template and fontawesome in one CSS file and any of them has some changes the users have to re download both but that's not the case if the files are not bundled (template.css+fa.css ~ 240kb but template.css ~ 180kb and fa.css ~ 80kb).
BTW this will only work if the new web assets are used as the old methods will always invalidate all the static assets per joomla release.

I'm in favour of this. My 2c

avatar brianteeman
brianteeman - comment - 7 Oct 2021

maybe its just me then that doesn't see the point in the admin template of doing this

avatar simbus82
simbus82 - comment - 8 Oct 2021

Nice! We have some projects where the backend admin is (from a commercial perspective) a "frontend" for many users, so every optimization is welcome!

avatar C-Lodder C-Lodder - change - 1 Feb 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 05:11:46
Closed_By C-Lodder
Labels Added: Conflicting Files NPM Resource Changed ?
avatar C-Lodder C-Lodder - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment