User tests: Successful: Unsuccessful:
/atum/scss/pages
contains page specific styling, which should be moved to separate CSS files, so that their only loaded on said specific page, rather than globally.
This PR moves the com_templates
styling to a separate CSS file
npm i
administrator/index.php?option=com_templates&view=styles
Menu Assignment
tabThe styling should be the same as before, but you should be able to confirm it derives from the separate CSS file:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_templates Templates (admin) NPM Change Repository |
If this is desired, then I suppose I can do the other pages.
does it really matter for so few lines
It's not so much the line count that matters, but spliting page specific CSS rather than just bundling everything up into a single file. No point in loading unused CSS where possible.
i dont really see the need myself for such micro-optimisation in the admin but if its done for one "page" it really should be done for all.
i dont really see the need myself for such micro-optimisation in the admin
It's a good thing to actually demonstrate best practices. We did this already for vendor (I think I did that) and the reason is cache invalidation, eg if we have template and fontawesome in one CSS file and any of them has some changes the users have to re download both but that's not the case if the files are not bundled (template.css+fa.css ~ 240kb but template.css ~ 180kb and fa.css ~ 80kb).
BTW this will only work if the new web assets are used as the old methods will always invalidate all the static assets per joomla release.
I'm in favour of this. My 2c
maybe its just me then that doesn't see the point in the admin template of doing this
Nice! We have some projects where the backend admin is (from a commercial perspective) a "frontend" for many users, so every optimization is welcome!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-01 05:11:46 |
Closed_By | ⇒ | C-Lodder | |
Labels |
Added:
Conflicting Files
NPM Resource Changed
?
|
will you be moving all the other pages and does it really matter for so few lines?