[#35775] - Add the transition name to workflow notification
- Fixed in Code Base
- 17 Oct 2021
- Medium
- Build: 4.0-dev
- # 35775
- Diff
- chmst:wirkflow-notification-message
User tests: Successful: Unsuccessful:
Pull Request for Issue #35694
Summary of Changes
As title says.
Testing Instructions
See issue.
Define a notification for a transition in an workflow.
Actual result BEFORE applying this Pull Request
see issue
Expected result AFTER applying this Pull Request
The message shows the name of the transition.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
I have tested this item
thank you
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35775.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35775.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-17 16:40:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Language Change
?
|
||
Thanks!
This is a b/c breaking change for language packs and language overrides as the ordering and therfore the value of the fields get changed right? Or is that not covered by the b/c policy?
The case where it breaks the language packs is:
- a old language pack (4.0.3v1) on 4.0.4 or newer
- a new language pack (4.0.4v1) on 4.0.3 or older
I've spent some time this morning looking at this this morning with @zero-24 - whilst it is a b/c break - we've decided not to revert as more packs in the last week have already translated than who haven't - and if we revert now we force all packs to re-update again on release day. Injecting the extra string won't break anything - it's just the order of injection that will cause issues with current packs.
Apologies and I take full responsibility for not picking up on @zero-24 's comment earlier when he posted it and getting it actioned immediately which would have headed this whole issue off at the pass.
I have tested this item✅ successfully on 84eb62b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35775.