? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Oct 2021

This PR adds the ability to mark your content with aside, article and section which are important landmarks that a content author may wish to use.

To test simply apply this PR and then you will find the new options as shown below.

You can then apply these containers to any blocks of content and verify that it worked either by toggling the editor or by displaying visual characters in tinymce from the toolbar button.

image

image

image

image

avatar brianteeman brianteeman - open - 1 Oct 2021
avatar brianteeman brianteeman - change - 1 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2021
Category Front End Plugins
avatar dgrammatiko
dgrammatiko - comment - 1 Oct 2021

Shouldn't those be in the Block dropdown? Also, capitalise the first letter?

avatar brianteeman
brianteeman - comment - 1 Oct 2021

As they are bigger than blocks I thought it best to place them in their own menu group. Containers can contain blocks.

I chose not to capitalise on purpose (after quite a bit of thought) as they are the name of the tags and not a descriptor of the tag (eg Paragraph for p)

avatar infograf768
infograf768 - comment - 2 Oct 2021

The word Containers is not included in TinyMce lang files (see https://github.com/joomla/joomla-cms/blob/ea93a288dab77fe237975f084f586a9241ce53dd/build/media_source/vendor/tinymce/langs/fr.es5.js)

In French it is Conteneurs (plural)
See https://developer.mozilla.org/fr/docs/Web/CSS/Containing_block

I guess it should be translatable and therefore we would need a new string.

avatar brianteeman brianteeman - change - 2 Oct 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2021
Category Front End Plugins Administration Language & Strings Front End Plugins
avatar Quiviro
Quiviro - comment - 22 Oct 2021

I have tested this item successfully on 05d476d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

avatar Quiviro Quiviro - test_item - 22 Oct 2021 - Tested successfully
avatar khu5h1 khu5h1 - test_item - 9 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 9 Nov 2021

I have tested this item successfully on 05d476d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

avatar brianteeman brianteeman - change - 10 Nov 2021
Labels Added: Language Change
avatar Quy Quy - change - 12 Nov 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

avatar bembelimen bembelimen - change - 13 Nov 2021
Labels Added: ?
avatar bembelimen bembelimen - change - 13 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-13 22:37:20
Closed_By bembelimen
avatar bembelimen bembelimen - close - 13 Nov 2021
avatar bembelimen bembelimen - merge - 13 Nov 2021
avatar bembelimen
bembelimen - comment - 13 Nov 2021

Thx

avatar brianteeman
brianteeman - comment - 13 Nov 2021

Thanks

Add a Comment

Login with GitHub to post a comment