[#35714] - [4.0] "(TEMPORARY)" css rules in main cassiopea template.scss
- Closed
- 7 Jan 2022
- Medium
- Build: 4.0-dev
- # 35714
Problem identified
In cassiopeia/scss/template.scss we have "temporary" css rules:
// Chosen (TEMPORARY)
.chzn-container-single {
width: auto !important;
}
.chzn-container-multi {
width: 100% !important;
max-width: 240px;
}Proposed solution
Remove / Transfer to a more suitable file.
Open questions
It is also present in /administrator/templates/atum/scss/blocks/_global.scss
// Chosen (TEMPORARY)
.chzn-container-single {
width: auto !important;
}
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
If I rightly remember, I added those when we started developing the J4 template and still used chosen.js.
I'm not sure if every chosen.js field was migrated over to choices.js.
It looks like there's still an entry for chosen-js in the web asset manager, but can't see it being used anywhere. Might be safe to remove the dependency completely, unless anyone knows if it's still being used somewhere or was kept for B/C purposes.
But yeah, if they're still being used, they should be moved to a different file. template.scss is the entrypoint and shouldn't contain rules.
I only know that the chosen has also some code in the build tools as well but for the question of why the dead thing called chosen is still in the dependencies I have no answer (and no involvement, was against chosen AND choices which is also abandoned)
I think can can be removed then
| Labels |
Added:
?
|
||
@drmenzelit can you have a look here?
@drmenzelit sorry, but no. I was curious as to why this CSS is still present despite Joomla! 4 coming out of beta.
Please review
Closing as having a pull request. Please test or review #36596 . Thanks in advance.
@niharikamahajan02 Could you give your pull request a more meaningful title? Maybe just copy the one of this issue here and add the word "Remove" after the "[4.0]", so it is:
[4.0] Remove "(TEMPORARY)" css rules in main cassiopea template.scss
Thanks in advance.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-07 11:17:53 |
| Closed_By | ⇒ | richard67 |
I only know that the chosen has also some code in the build tools as well but for the question of why the dead thing called chosen is still in the dependencies I have no answer (and no involvement, was against chosen AND choices which is also abandoned)
Pretty sure you proposed choices ;) joomla/40-backend-template#19 (comment)
But also chosen was included as a b/c for j3.x components until they could move to J4 and use the at the time modern choices.js. Choices is back to being maintained again at least for now by the way. They found a new maintainer.
Why?