[#35716] - Smart Search Module Minfication
- Closed
- 2 Oct 2021
- Medium
- Build: Daraja
- # 35716
Using a template with Minification turned on the smart search module auto-suggest does not work. Posted in Gridbox forum.
https://support.balbooa.com/forum/gridbox/13881-smart-search-module#65459
The developer says it's caused by one-line comments.
Steps to reproduce the issue
Enable minifcation in Gridbox template, type in smart search module input field.
Expected result
Auto-suggest should populate suggestions
Actual result
No auto-suggest box opens on a page with HTML modification. This works on the actual search results page where the page is not minified.
System information (as much as possible)
Joomla! 3.10.2
PHP Version 7.4.24
Gridbox template
Additional comments
This module will not work with enabled minimization since their using 1-line comments in the code.
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
The comments are totally valid. The software that you are using just doesn’t handle those correctly. Personally I wouldn’t change anything in the core and I would created a ticket on the other software
I'll let them know. Is there a way to test this with the core Joomla template? Does Joomla 4 have minifcation?
Joomla 4 doesn’t use inline scripts almost nowhere…
So this won't be an issue in Joomla 4 when using Gridbox? If that is the case it's a moot point.
Well, their code is broken, so you might not have a problem with core Joomla but most probably you will with some 3rd party extensions.
Also, concatenating scripts is NOT a best practice for many years, so the whole point here is kinda seriously outdated and baggy
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-02 16:35:27 |
| Closed_By | ⇒ | DaveOzric |
Thanks for your help.
Sounds very odd but you can remove the comments yourself by creating a template override for the module