[#35322] - [4.1] Automating the rmrf on the startup of the (npm) build tools
- Fixed in Code Base
- 28 Jan 2022
- Medium
- Build: 4.0-dev
- # 35322
- Diff
- dgrammatiko:4.0-Automate
User tests: Successful: Unsuccessful:
Pull Request for Issue #35198 .
Summary of Changes
With #35198 we introduced a registry for all the folders of the media folder. This PR just automates the creation/update of that registry.
Testing Instructions
This PR needs npm
- modify the
build/build.jsso that line 157 to line 171 are muted eg:
// Prepare the repo for dev work
if (Program.prepare) {
const bench = new Timer('Build');
allowedVersion();
recreateMediaFolder(options)
// .then(() => cleanVendors())
// .then(() => localisePackages(options))
// .then(() => Promise.all(
// [
// patchPackages(options),
// minifyVendor(),
// createErrorPages(options),
// stylesheets(options, Program.args[0]),
// scripts(options, Program.args[0]),
// bootstrapJs(),
// mediaManager(true)
// ]))
// .then(() => bench.stop('Build'))
// .then(() => { process.exit(0); })
.catch((err) => {
// eslint-disable-next-line no-console
console.error(err);
process.exit(-1);
});
}and also mute line 73 of build/build-modules-js/init/recreate-media.es6.js // await copy(join(RootPath, 'build/media_source'), join(RootPath, 'media'), { filter: filterFunc });
- Run
node ./build/build.js --prepare - Check that all the existing folders in the
mediaare empty and any non-core Joomla extensions are unaffected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
@richard67 this is the missing part you were asking at #35198
@wilsonge @HLeithner this one actually needs to run with a GitHub action on every merge, let me know if you want me to add the action here or is something for you...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
Is there a reason we put this as a config setting rather than just generating this list of directories at run time?
That will work also. I'm tweaking the code to do that... (hopefully, I won't recall some weird edge case that the registry is needed)
@dgrammatiko i think you didn't push :)
| Labels |
Added:
?
Removed: ? |
||
@dgrammatiko i think you didn't push :)
Don't you love Github's PWA? It's a caching thing, try hard reload to see the commit...
| Labels |
Added:
?
Removed: ? |
||
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
Removed: ? |
||
do we really need this after each merge?
do we really need this after each merge?
No, not anymore the code is auto-generating the list at runtime. Sorry, I forgot to remove the comment above...
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35322.
@richard67 could you test this one?
@richard67 could you test this one?
@dgrammatiko Not before late tonight or tomorrow, not sure yet when.
@bembelimen Maybe this one should be rebased to 4.1-dev, too? If that works cleanly we could maybe still count the one human test which is has right now.
| Labels |
Added:
?
Removed: ? |
||
Maybe this one should be rebased to 4.1-dev, too?
I did it through the GitHub UI and I guess it worked
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-28 13:25:37 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
LGTM. Thanks!
Thanks George!
Thanks for saving me time for testing
Is there a reason we put this as a config setting rather than just generating this list of directories at run time?