User tests: Successful: Unsuccessful:
Code review
Security 101: Do not provide guessable defaults for secrets or credentials because users cannot be trusted to change default credentials and secrets.
Also can be used to fingerprint/google dork.
Status | New | ⇒ | Pending |
Category | ⇒ | Installation |
regardless of the actual number or the stupidness of people... not providing defaults for otherwise secure credentials is security 101.
I have tested this item
The secret is generated on install, so IMHO the default can be removed.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
So what happens if a user uses this file and forgots to add a secret? Does any place in Joomla! crashes, because there is no secret?
Additional probably we should extend the comment to help the user to define a secret (16 characters, uppercase, lowercase alphanumeric, ...)
So what happens if a user uses this file and forgots to add a secret? Does any place in Joomla! crashes, because there is no secret?
Joomla runs as normal. Joomla does not validate the secret, and does not care that there is not one defined.
Additional probably we should extend the comment to help the user to define a secret (16 characters, uppercase, lowercase alphanumeric, ...)
No we absolutely should not. This goes against all security best practice in 2021, the same way it is now around upon to provide and enforce password policies other than length. As Joomla can accept a empty string as a secret (rightly or wrongly) any artificial complexity rules are simply wrong.
Labels |
Added:
?
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-09 17:15:11 |
Closed_By | ⇒ | wilsonge |
Thanks!
You really cant fix stupid. There are only 88 instances on github and they also include server passwords and usernames which is far more serious for them than the secret.
Some people deserve to be hacked